[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: DMS RemoveResources: Inform the ResourceWatcherManager about the chang
From: "Sebastian Trueg" <sebastian () trueg ! de>
Date: 2012-09-04 13:17:20
Message-ID: 20120904131720.14943.58443 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106320/#review18498
-----------------------------------------------------------
Actually I would use ResourceManagerWatcher::getTypes() in ResourceManagerW=
atcher::removeResource if "types" is empty. It reuses existing code. All th=
at is left then is to move the removeResource call as you already did.
- Sebastian Trueg
On Sept. 4, 2012, 12:11 p.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106320/
> -----------------------------------------------------------
> =
> (Updated Sept. 4, 2012, 12:11 p.m.)
> =
> =
> Review request for Nepomuk and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> Inform the ResourceWatcherManager that the resources have been remove=
d,
> along with their respective types.
> =
> This requires additional querying in order to determine the type, but=
we
> need it so there is no way around it.
> =
> =
> Diffs
> -----
> =
> services/storage/datamanagementmodel.cpp 69c046d =
> =
> Diff: http://git.reviewboard.kde.org/r/106320/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106320/">http://git.reviewboard.kde.org/r/106320/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually I would use \
ResourceManagerWatcher::getTypes() in ResourceManagerWatcher::removeResource if \
"types" is empty. It reuses existing code. All that is left then is to move \
the removeResource call as you already did.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On September 4th, 2012, 12:11 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2012, 12:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Inform the ResourceWatcherManager that the resources have been \
removed, along with their respective types.
This requires additional querying in order to determine the type, but we
need it so there is no way around it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/datamanagementmodel.cpp <span style="color: \
grey">(69c046d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106320/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic