[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: CHANGE: use TPE2 tag as nmm:albumArtist in id3 tags
From: "Sebastian Trueg" <sebastian () trueg ! de>
Date: 2012-06-27 7:18:52
Message-ID: 20120627071852.20539.42810 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105362/#review15188
-----------------------------------------------------------
Ship it!
The code looks good, it is tested. I cannot say much regarding your stateme=
nt about the de-facto standard, I trust you here.
- Sebastian Trueg
On June 26, 2012, 4:59 p.m., Ignacio Serantes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105362/
> -----------------------------------------------------------
> =
> (Updated June 26, 2012, 4:59 p.m.)
> =
> =
> Review request for Nepomuk and Strigi.
> =
> =
> Description
> -------
> =
> A minor change to use TPE2 as nmm:albumArtist to be coherent with other f=
ormats, like flac or ogg. This change it's not following the id3 specificat=
ion, http://www.id3.org/id3v2.4.0-frames, but seems to be a "de facto" stan=
dard: kid3, easyTag, iTunes, Windows Media Player, etc...
> =
> =
> Diffs
> -----
> =
> lib/endanalyzers/id3endanalyzer.cpp 0db3728 =
> =
> Diff: http://git.reviewboard.kde.org/r/105362/diff/
> =
> =
> Testing
> -------
> =
> Tested with some mp3 files with none, one and two album artists using uni=
code characters.
> =
> =
> Thanks,
> =
> Ignacio Serantes
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105362/">http://git.reviewboard.kde.org/r/105362/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code looks good, it \
is tested. I cannot say much regarding your statement about the de-facto standard, I \
trust you here.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On June 26th, 2012, 4:59 p.m., Ignacio Serantes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Strigi.</div>
<div>By Ignacio Serantes.</div>
<p style="color: grey;"><i>Updated June 26, 2012, 4:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A minor change to use TPE2 as nmm:albumArtist to be coherent with other \
formats, like flac or ogg. This change it's not following the id3 specification, \
http://www.id3.org/id3v2.4.0-frames, but seems to be a "de facto" standard: \
kid3, easyTag, iTunes, Windows Media Player, etc...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with some mp3 files with none, one and two album artists using \
unicode characters.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/endanalyzers/id3endanalyzer.cpp <span style="color: \
grey">(0db3728)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105362/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic