[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Remove threading code from nepomuksearch kio slave
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2012-06-15 16:49:17
Message-ID: 20120615164917.23051.11275 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 15, 2012, 2:50 p.m., Sebastian Trueg wrote:
> > I think this is correct. But I cannot remember exactly why I introduced=
the thread in the first place. So I am not entirely sure. But if you teste=
d everything including automatic query updates then this should be fine.
> > Actually I suppose we could improve the performance even more by not us=
ing the query service...
I'll test it more. I've checked out the BlueDevil code, and they do it in t=
he pretty much same way.
Even I wanted to not use the QueryService, but we need query updates. Maybe=
we could abstract away the query service stuff and just do it in the query=
service?
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105255/#review14761
-----------------------------------------------------------
On June 14, 2012, 11:28 p.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105255/
> -----------------------------------------------------------
> =
> (Updated June 14, 2012, 11:28 p.m.)
> =
> =
> Review request for Nepomuk and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> The extra QThread isn't really required and complicates the code, and als=
o adds an unnecessary overhead.
> =
> =
> Diffs
> -----
> =
> nepomuk/kioslaves/search/kio_nepomuksearch.h e68ff29 =
> nepomuk/kioslaves/search/kio_nepomuksearch.cpp 38894be =
> nepomuk/kioslaves/search/searchfolder.h c0839b5 =
> nepomuk/kioslaves/search/searchfolder.cpp 8088c46 =
> =
> Diff: http://git.reviewboard.kde.org/r/105255/diff/
> =
> =
> Testing
> -------
> =
> Works exactly the same as before.
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105255/">http://git.reviewboard.kde.org/r/105255/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 15th, 2012, 2:50 p.m., <b>Sebastian \
Trueg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think this is correct. But I cannot remember exactly why I introduced \
the thread in the first place. So I am not entirely sure. But if you tested \
everything including automatic query updates then this should be fine. Actually I \
suppose we could improve the performance even more by not using the query \
service...</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll test it more. \
I've checked out the BlueDevil code, and they do it in the pretty much same way.
Even I wanted to not use the QueryService, but we need query updates. Maybe we could \
abstract away the query service stuff and just do it in the query service?</pre> <br \
/>
<p>- Vishesh</p>
<br />
<p>On June 14th, 2012, 11:28 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 14, 2012, 11:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The extra QThread isn't really required and complicates the code, \
and also adds an unnecessary overhead.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works exactly the same as before.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kioslaves/search/kio_nepomuksearch.h <span style="color: \
grey">(e68ff29)</span></li>
<li>nepomuk/kioslaves/search/kio_nepomuksearch.cpp <span style="color: \
grey">(38894be)</span></li>
<li>nepomuk/kioslaves/search/searchfolder.h <span style="color: \
grey">(c0839b5)</span></li>
<li>nepomuk/kioslaves/search/searchfolder.cpp <span style="color: \
grey">(8088c46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105255/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic