[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Set the main type as the type highest in the hierarachy
From: "Sebastian Trueg" <sebastian () trueg ! de>
Date: 2012-06-15 14:57:09
Message-ID: 20120615145709.12966.28791 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105265/#review14763
-----------------------------------------------------------
nepomuk/core/resourcedata.cpp
<http://git.reviewboard.kde.org/r/105265/#comment11645>
"Note" is a sub class of "HTMLDoc". We want to use "Note" if "HTMLDoc" =
is our current type. Thus, the test is: if the storedtype (Note) isSubClass=
Of the current type (HTMLDoc) -> use the stored type.
- Sebastian Trueg
On June 15, 2012, 11:34 a.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105265/
> -----------------------------------------------------------
> =
> (Updated June 15, 2012, 11:34 a.m.)
> =
> =
> Review request for Nepomuk and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> It makes more sense show "Note" instead of "HTML Document".
> =
> =
> Diffs
> -----
> =
> nepomuk/core/resourcedata.cpp 4e8554d =
> =
> Diff: http://git.reviewboard.kde.org/r/105265/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105265/">http://git.reviewboard.kde.org/r/105265/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105265/diff/1/?file=67802#file67802line370" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk/core/resourcedata.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Nepomuk::ResourceData::loadType( const QUrl& storedType )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">370</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span> <span \
class="n">storedTypeClass</span><span class="p">.</span><span \
class="n">isSubClassOf</span><span class="p">(</span> <span \
class="n">currentTypeClass</span> <span class="p">)</span> <span class="p">)</span> \
<span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">370</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span> <span class="o"><span class="hl">!</span></span><span \
class="n">storedTypeClass</span><span class="p">.</span><span \
class="n">isSubClassOf</span><span class="p">(</span> <span \
class="n">currentTypeClass</span> <span class="p">)</span> <span class="p">)</span> \
<span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"Note" is a sub class of "HTMLDoc". We want to use \
"Note" if "HTMLDoc" is our current type. Thus, the test is: if \
the storedtype (Note) isSubClassOf the current type (HTMLDoc) -> use the stored \
type.</pre> </div>
<br />
<p>- Sebastian</p>
<br />
<p>On June 15th, 2012, 11:34 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 15, 2012, 11:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It makes more sense show "Note" instead of "HTML \
Document". </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/core/resourcedata.cpp <span style="color: grey">(4e8554d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105265/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic