[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Fix: non numeric genres in id3 v2 mp3 are ignored.
From: "Ignacio Serantes" <kde () aynoa ! net>
Date: 2012-06-14 9:40:38
Message-ID: 20120614094038.19995.18703 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 13, 2012, 8:25 p.m., Sebastian Trueg wrote:
> > lib/endanalyzers/id3endanalyzer.cpp, line 524
> > <http://git.reviewboard.kde.org/r/105242/diff/1/?file=67582#file67582line524>
> >
> > Would it make sense to check the value or is ot ok to just allow any string to be the genre?
Any string because there are genres not in the list like K-Pop or Kpop.
- Ignacio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105242/#review14705
-----------------------------------------------------------
On June 14, 2012, 9:38 a.m., Ignacio Serantes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105242/
> -----------------------------------------------------------
>
> (Updated June 14, 2012, 9:38 a.m.)
>
>
> Review request for Nepomuk, Strigi and Vishesh Handa.
>
>
> Description
> -------
>
> If genre is stored in a non numeric format genre is not imported.
>
>
> Diffs
> -----
>
> lib/endanalyzers/id3endanalyzer.cpp d8487b5
>
> Diff: http://git.reviewboard.kde.org/r/105242/diff/
>
>
> Testing
> -------
>
> Testing with and without a genre in string form.
>
>
> Thanks,
>
> Ignacio Serantes
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105242/">http://git.reviewboard.kde.org/r/105242/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 13th, 2012, 8:25 p.m., <b>Sebastian \
Trueg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105242/diff/1/?file=67582#file67582line524" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/endanalyzers/id3endanalyzer.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">ID3EndAnalyzer::analyze(Strigi::AnalysisResult& indexable, Strigi::InputStream* \
in) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">524</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span> <span \
class="n">indexable</span><span class="p">.</span><span \
class="n">addValue</span><span class="p">(</span><span class="n">factory</span><span \
class="o">-></span><span class="n">genreField</span><span class="p">,</span> <span \
class="n">value</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would it make sense to \
check the value or is ot ok to just allow any string to be the genre?</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any string \
because there are genres not in the list like K-Pop or Kpop.</pre> <br />
<p>- Ignacio</p>
<br />
<p>On June 14th, 2012, 9:38 a.m., Ignacio Serantes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk, Strigi and Vishesh Handa.</div>
<div>By Ignacio Serantes.</div>
<p style="color: grey;"><i>Updated June 14, 2012, 9:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If genre is stored in a non numeric format genre is not imported.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing with and without a genre in string form.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/endanalyzers/id3endanalyzer.cpp <span style="color: \
grey">(d8487b5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105242/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic