'[Nepomuk] Review Request: Signal the End of Ontology Loading on DBus'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nepomuk
Subject:    [Nepomuk] Review Request: Signal the End of Ontology Loading on DBus
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2012-05-16 2:29:31
Message-ID: 20120516022931.26538.45445 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104964/
-----------------------------------------------------------

Review request for Nepomuk.

Description
-------

Since ontologies are loaded asynchronously, the end of the loading process should be \
made available through DBus. I can provide the patch for Nepomuk Core too if needed.

This addresses bug 298684.
    http://bugs.kde.org/show_bug.cgi?id=298684

Diffs
-----

  nepomuk/interfaces/org.kde.nepomuk.OntologyManager.xml 8977b79 
  nepomuk/services/storage/nepomukcore.cpp 116350c 
  nepomuk/services/storage/ontologyloader.h 4e0ce26 
  nepomuk/services/storage/ontologyloader.cpp c06a297 

Diff: http://git.reviewboard.kde.org/r/104964/diff/

Testing
-------

1) Log into a session
2) Open a terminal and type

dbus-monitor "type='signal',interface='org.kde.nepomuk.OntologyManager',member='ontologyLoadingFinished'"

3) Wait for the ontologies to finish loading, you should see dbus-monitor reporting \
the signal

Thanks,

David Narváez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104964/">http://git.reviewboard.kde.org/r/104964/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk.</div>
<div>By David Narváez.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since ontologies are loaded asynchronously, the end of the loading \
process should be made available through DBus. I can provide the patch for Nepomuk \
Core too if needed.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Log into a session 2) Open a terminal and type

dbus-monitor &quot;type=&#39;signal&#39;,interface=&#39;org.kde.nepomuk.OntologyManager&#39;,member=&#39;ontologyLoadingFinished&#39;&quot;

3) Wait for the ontologies to finish loading, you should see dbus-monitor reporting \
the signal</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=298684">298684</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>nepomuk/interfaces/org.kde.nepomuk.OntologyManager.xml <span style="color: \
grey">(8977b79)</span></li>

 <li>nepomuk/services/storage/nepomukcore.cpp <span style="color: \
grey">(116350c)</span></li>

 <li>nepomuk/services/storage/ontologyloader.h <span style="color: \
grey">(4e0ce26)</span></li>

 <li>nepomuk/services/storage/ontologyloader.cpp <span style="color: \
grey">(c06a297)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104964/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk

[prev in list] [next in list] [prev in thread] [next in thread] 