[prev in list] [next in list] [prev in thread] [next in thread]
List: nepomuk
Subject: Re: [Nepomuk] Review Request: Do not reindex files on only WriteOnClose Events
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-01-26 13:48:32
Message-ID: 20120126134832.1138.97364 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103794/#review10091
-----------------------------------------------------------
The only thing I don't like from this approach is that we are listening now=
for an even that could happen a LOT of times and we only need it one time =
so it seems to me like a waste of resources.
The low level inotify has a way of listening only 1 time for an event, can =
we export that functionality? if not, can we at least change the mask once =
we got the frirst Modify event?
Also something stupid but important for some people, is Nepomuk following k=
delibs style? if it is then you are missing {} (and if nepomuk is not follo=
wing it should :p)
- Alex Fiestas
On Jan. 26, 2012, 12:41 p.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103794/
> -----------------------------------------------------------
> =
> (Updated Jan. 26, 2012, 12:41 p.m.)
> =
> =
> Review request for Nepomuk, Alex Fiestas and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> This Filewatcher sends files for reindexing when it receives a WriteOnClo=
se event from inotify. This event is generated whenever a file opened in wr=
ite mode is closed. Even if they were no changes.
> =
> Programs like Amarok and KTorrent often open the files in write mode even=
when they don't make any changes. Which results in reindexing of those fil=
es.
> =
> For a graphical example - http://www.afiestas.org/nepomukReindexing.ogv
> =
> =
> Diffs
> -----
> =
> nepomuk/services/filewatch/activefilequeue.h 19d4813 =
> nepomuk/services/filewatch/activefilequeue.cpp 8bb54ed =
> nepomuk/services/filewatch/nepomukfilewatch.h cfb02fc =
> nepomuk/services/filewatch/nepomukfilewatch.cpp 60550c2 =
> nepomuk/services/filewatch/test/activefilequeuetest.cpp 0445e8f =
> =
> Diff: http://git.reviewboard.kde.org/r/103794/diff/diff
> =
> =
> Testing
> -------
> =
> All the tests pass, and files are no longer reindexed when the song chang=
es in Amarok.
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103794/">http://git.reviewboard.kde.org/r/103794/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only thing I \
don't like from this approach is that we are listening now for an even that could \
happen a LOT of times and we only need it one time so it seems to me like a waste of \
resources.
The low level inotify has a way of listening only 1 time for an event, can we export \
that functionality? if not, can we at least change the mask once we got the frirst \
Modify event?
Also something stupid but important for some people, is Nepomuk following kdelibs \
style? if it is then you are missing {} (and if nepomuk is not following it should \
:p)</pre> <br />
<p>- Alex</p>
<br />
<p>On January 26th, 2012, 12:41 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk, Alex Fiestas and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2012, 12:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This Filewatcher sends files for reindexing when it receives a \
WriteOnClose event from inotify. This event is generated whenever a file opened in \
write mode is closed. Even if they were no changes.
Programs like Amarok and KTorrent often open the files in write mode even when they \
don't make any changes. Which results in reindexing of those files.
For a graphical example - http://www.afiestas.org/nepomukReindexing.ogv</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All the tests pass, and files are no longer reindexed when the song \
changes in Amarok.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/services/filewatch/activefilequeue.h <span style="color: \
grey">(19d4813)</span></li>
<li>nepomuk/services/filewatch/activefilequeue.cpp <span style="color: \
grey">(8bb54ed)</span></li>
<li>nepomuk/services/filewatch/nepomukfilewatch.h <span style="color: \
grey">(cfb02fc)</span></li>
<li>nepomuk/services/filewatch/nepomukfilewatch.cpp <span style="color: \
grey">(60550c2)</span></li>
<li>nepomuk/services/filewatch/test/activefilequeuetest.cpp <span style="color: \
grey">(0445e8f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103794/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Nepomuk mailing list
Nepomuk@kde.org
https://mail.kde.org/mailman/listinfo/nepomuk
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic