[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nano-devel
Subject:    Re: [Nano-devel] [PATCH] Fix segfault when executing an empty command in a new buffer
From:       Benno Schulenberg <bensberg () telfort ! nl>
Date:       2017-10-28 10:47:43
Message-ID: 3d058db2-a58d-cb3e-e554-30fe349bb9d9 () telfort ! nl
[Download RAW message or body]


Op 27-10-2017 om 19:09 schreef Marco Diego Aurélio Mesquita:
> The attached patch fixes a segfault when creating a new empty buffer.
> To reproduce the bug, start nano, hit ^R ^X M-F Enter. Behavior maybe
> different depending on the architecture you're running.
> 
> The defect was introduced in c8363a0d.

Thanks for finding that.

However, I do not like the fix.  All other calls of update_history()
avoid making the call when the string is empty.  And in this case
that is the better option, because it is also pointless to *execute*
the command when it is empty.  So I have pushed a fix to that effect:
84c650b8.

Benno


_______________________________________________
Nano-devel mailing list
Nano-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/nano-devel

[prev in list] [next in list] [prev in thread] [next in thread]