[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nagios-devel
Subject:    Re: [Nagios-devel] Nagios Core 3.5.0rc2
From:       eponymous alias <eponymousalias () yahoo ! com>
Date:       2013-03-19 0:48:37
Message-ID: 1363654117.78949.YahooMailClassic () web121102 ! mail ! ne1 ! yahoo ! com
[Download RAW message or body]

Sorry, I should have caught this trivial fix before the final release was o=
ut.  In common/macros.c, the current
code says:

#include "../include/macros.h"
#include "../include/config.h"

But this doesn't do the right thing, with regard to
defining the _GNU_SOURCE symbol so the compiler doesn't
complain about the asprintf() calls.  The problem is that
macros.h eventually includes <time.h>, which itself
includes <features.h>, which is where _GNU_SOURCE gets
turned into the __USE_GNU symbol that is actually used
in <stdio.h> to provide a definition for asprintf().
So the definition of _GNU_SOURCE at the top of config.h
comes too late to do any good.

Long story short, the order of those two lines in
common/macros.c needs to be reversed:

#include "../include/config.h"
#include "../include/macros.h"

Also in the way of trivial fixes, compilation of
cgiutils.c yields the warning:

cgiutils.c: In function 'include_ssi_files':
cgiutils.c:1571: warning: unused variable 'x'

This ought to be suppressed by removing the obsolete
declaration.

--- On Sat, 3/9/13, Eric Stanley <estanley@nagios.com> wrote:

> From: Eric Stanley <estanley@nagios.com>
> Subject: [Nagios-devel] Nagios Core 3.5.0rc2
> To: "Nagios Developers List" <nagios-devel@lists.sourceforge.net>
> Date: Saturday, March 9, 2013, 2:37 PM
> I have just uploaded another Nagios
> Core release candidate. Thanks to =

> Phil Randal for find and reporting an issue.
> =

> You can download the 3.5.0rc2 tarball from =

> http://sourceforge.net/projects/nagios/files/nagios-3.x/nagios-3.5.0/nagi=
os-3.5.0rc2.tar.gz/download.
> =

> Feel free to compile and try it out. I will release 3.5.0
> about midweek =

> unless I hear of significant issues.
> =

> The complete changelog since 3.4.4 is as follows:
> =

> * Fixed bug #403: The "configuration" page of the webui
> doesn't use =

> entity encoding
> when displaying the "command expansion" item (Eric Stanley,
> Phil Randal)
> * Fixed bug #424: Nagios Core 3.4.4 seg fault (core dump) on
> restart =

> after removing
> config for running service (Eric Stanley)
> * Updated CGI utility functions to support UTF-8 characters
> (Eric Stanley)
> * Fixed bug where selecting Command Expansion from
> Configuration CGI =

> page would disp
> lay commands instead (Eric Stanley)
> * Fixed bug #369: status.cgi crashes with segfault when
> there are german =

> ulauts (=E4=F6=FC
> =DF) in the hostname or the servicename (Eric Stanley)
> * Fixed bug #418: Scheduled Downtime Notifications Resent On
> Nagios =

> Restart/reload (
> Eric Stanley)
> =

> -- =

> Eric Stanley
> ___
> Developer
> Nagios Enterprises, LLC
> Email:=A0 estanley@nagios.com
> Web:=A0 =A0 www.nagios.com
> =

> =

> -------------------------------------------------------------------------=
-----
> Symantec Endpoint Protection 12 positioned as A LEADER in
> The Forrester=A0 =

> Wave(TM): Endpoint Security, Q1 2013 and "remains a good
> choice" in the=A0 =

> endpoint security space. For insight on selecting the right
> partner to =

> tackle endpoint security challenges, access the full report.
> =

> http://p.sf.net/sfu/symantec-dev2dev
> _______________________________________________
> Nagios-devel mailing list
> Nagios-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nagios-devel
> =


---------------------------------------------------------------------------=
---
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Nagios-devel mailing list
Nagios-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel
[prev in list] [next in list] [prev in thread] [next in thread]