[prev in list] [next in list] [prev in thread] [next in thread]
List: nagios-devel
Subject: Re: [Nagios-devel] Tinderbox builds
From: Allan Clark <allanc () chickenandporn ! com>
Date: 2009-08-24 11:32:52
Message-ID: 37c712e0908240432t42629cabv2384d5142111ee69 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Mon, Aug 24, 2009 at 11:58, Sébastien Barbereau <barbereau@gmail.com>wrote:
> On Fri, Aug 21, 2009 at 2:54 PM, Ton Voon <ton.voon@opsera.com> wrote:
>
>>
>> On 21 Aug 2009, at 09:52, Hiren Patel wrote:
>>
>> Ton Voon wrote:
>>
>> Hi!
>>
>>
>> I've setup the required central server for Tinderbox builds now. I've
>>
>> added a server so this is run every 24 hours now.
>>
>>
>> Status page: http://tinderbox.nagios.org/nagios/status.html
>>
>>
>> Information page: http://tinderbox.nagios.org (redirects to wiki)
>>
>>
>> If you care about Nagios building and running correctly on your
>>
>> platform of choice, please take a look at the pages to setup tinderbox
>>
>> builds on your systems. I'll be pleased to setup the necessary access
>>
>> for you to send your reports to the central server.
>>
>>
>>
>> interesting, and nice :)
>> what platforms do we currently have builds for?
>>
>>
>> That's easy - look at: http://tinderbox.nagios.org/nagios/status.html
>>
>> I could add more, but actually, I want more participation from the
>> community.
>>
>> and which are the most
>> common ones we want to start out with?
>>
>>
>> Add which ever ones you are interested in. There's the ability to add in
>> configure options, so I can see that you may want to test that certain
>> configure options work as expected.
>>
>> Ton
>>
>
> Hi,
> not sure what i'm missing here but I was trying to use the tinderbox_build
on a fresh nagios-head and
> I get a bunch of error related to the tap library. Replacing the
nagios/tap dir by the original source code
> branch from
http://people.freebsd.org/~nik/public_distfiles/tap-1.01.tar.gz seem to
magically resolve the
> issues.
> This seem particularly strange to me as the only modification is in the
tap.c file for the threads parts.
> Anyone has a clue on why I see this and how to fix it properly? (I was
suspecting some autoconf/automake
> weirdness related to the generated libtool)
>
> Seb.
I've found a timezone-related issue, sounds a bit different though: the
following resolves the error I had with tinderbox builds outside of
BST/UTC+1 timezone. The epoch time is hard-coded, so I shifted all logging
to UTC, but that uses the base/logging function, and might shift everyone's
log files off a few hours.
I can do this through configure.in if it's preferred. At least this is the
rootcause of the error I have been having.
Index: base/logging.c
===================================================================
RCS file: /cvsroot/nagios/nagios/base/logging.c,v
retrieving revision 1.41
diff -r1.41 logging.c
395c395
< t=localtime(&rotation_time);
---
> t=gmtime(&rotation_time); /* see t-tap/var/nagios.log.expected, and a note
near t-tap/test_logging.c@81 look for "base/logging.c@395" */
cvs diff: Diffing t-tap
Index: t-tap/test_logging.c
===================================================================
RCS file: /cvsroot/nagios/nagios/t-tap/test_logging.c,v
retrieving revision 1.2
diff -r1.2 test_logging.c
79a80,88
> /*
> * this was UTC+1 or BST timezone working with base/logging.c@395:
t=localtime(&rotation_time)
> * - not an error until they have to coincide. Problem is, this isn't an
error so long as the
> * Nagios server never changes timezones because the log files will always
be created in
> * local timezone, and rotated on local time. In effect, by putting an
epoch-based time
> * here, you're effectively requiring that all tinderbox servers be in the
same timezone.
> * Switching to gmtime effectively neutralizes, but puts everyone in UTC,
which is an
> * hour off. Adjusting the epoch to match.
> *
80a90,91
> */
> rotation_time = (time_t)1242953298; /* + 3600 ,
t-tap/var/nagios.log.expected altered to match */
cvs diff: Diffing t-tap/var
Index: t-tap/var/nagios.log.expected
===================================================================
RCS file: /cvsroot/nagios/nagios/t-tap/var/nagios.log.expected,v
retrieving revision 1.1
diff -r1.1 nagios.log.expected
1c1
< [1242949698] LOG ROTATION: HOURLY
---
> [1242953298] LOG ROTATION: HOURLY
3c3
< [1242949698] LOG VERSION: 2.0
---
> [1242953298] LOG VERSION: 2.0
--
allanc@chickenandporn.com "金鱼" http://tech.chickenandporn.com/tags/nagios/
[Attachment #5 (text/html)]
<div class="gmail_quote">On Mon, Aug 24, 2009 at 11:58, Sébastien Barbereau <span \
dir="ltr"><<a href="mailto:barbereau@gmail.com">barbereau@gmail.com</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="gmail_quote"><div><div class="h5">On Fri, \
Aug 21, 2009 at 2:54 PM, Ton Voon <span dir="ltr"><<a \
href="mailto:ton.voon@opsera.com" target="_blank">ton.voon@opsera.com</a>></span> \
wrote:<br></div></div><blockquote class="gmail_quote" style="border-left:1px solid \
rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex"> <div><div></div><div \
class="h5"> <div style="word-wrap:break-word"><br><div><div><div>On 21 Aug 2009, at \
09:52, Hiren Patel wrote:</div><br><blockquote type="cite"><div>Ton Voon \
wrote:<br><blockquote type="cite">Hi!<br></blockquote><blockquote type="cite">
<br></blockquote><blockquote type="cite">I've setup the required central server \
for Tinderbox builds now. I've <br></blockquote><blockquote type="cite">added a \
server so this is run every 24 hours now.<br></blockquote>
<blockquote type="cite"><br></blockquote><blockquote type="cite">Status page: <a \
href="http://tinderbox.nagios.org/nagios/status.html" \
target="_blank">http://tinderbox.nagios.org/nagios/status.html</a><br></blockquote><blockquote \
type="cite">
<br></blockquote><blockquote type="cite">Information page: <a \
href="http://tinderbox.nagios.org" target="_blank">http://tinderbox.nagios.org</a> \
(redirects to wiki)<br></blockquote><blockquote type="cite"><br></blockquote>
<blockquote type="cite">If you care about Nagios building and running correctly on \
your <br></blockquote><blockquote type="cite">platform of choice, please take a \
look at the pages to setup tinderbox <br></blockquote><blockquote type="cite">
builds on your systems. I'll be pleased to setup the necessary access \
<br></blockquote><blockquote type="cite">for you to send your reports to the central \
server.<br></blockquote><blockquote type="cite"><br></blockquote>
<br>interesting, and nice :)<br>what platforms do we currently have builds for? \
</div></blockquote><div><br></div></div>That's easy - look at: <a \
href="http://tinderbox.nagios.org/nagios/status.html" \
target="_blank">http://tinderbox.nagios.org/nagios/status.html</a></div>
<div><br></div><div>I could add more, but actually, I want more participation from \
the community.</div><div><br></div><div><div><blockquote type="cite"><div>and which \
are the most <br>common ones we want to start out with?</div>
</blockquote><div><br></div></div><div>Add which ever ones you are interested in. \
There's the ability to add in configure options, so I can see that you may want \
to test that certain configure options work as expected.</div>
<div><br></div></div><font \
color="#888888">Ton<div></div></font></div></div></div></blockquote></div></blockquote><div><br></div><div><br></div><div>> \
Hi,<br>> not sure what i'm missing here but I was trying to use the \
tinderbox_build on a fresh nagios-head and </div> <div>> I get a bunch of error \
related to the tap library. Replacing the nagios/tap dir by the original source \
code</div><div>> branch from <a \
href="http://people.freebsd.org/~nik/public_distfiles/tap-1.01.tar.gz" \
target="_blank">http://people.freebsd.org/~nik/public_distfiles/tap-1.01.tar.gz</a> \
seem to magically resolve the</div> <div>> issues.<br>> This seem particularly \
strange to me as the only modification is in the tap.c file for the threads \
parts.</div><div>> Anyone has a clue on why I see this and how to fix it properly? \
(I was suspecting some autoconf/automake</div> <div>> weirdness related to the \
generated libtool)<br>><br>> Seb.<br><div \
class="gmail_quote"><div><div></div></div></div></div><div><br></div><div><div>I've \
found a timezone-related issue, sounds a bit different though: the following \
resolves the error I had with tinderbox builds outside of BST/UTC+1 timezone. The \
epoch time is hard-coded, so I shifted all logging to UTC, but that uses the \
base/logging function, and might shift everyone's log files off a few \
hours.</div> <div><br></div><div>I can do this through <a \
href="http://configure.in">configure.in</a> if it's preferred. At least this is \
the rootcause of the error I have been \
having.</div><div><br></div><div><br></div><div><br> </div><div><div>Index: \
base/logging.c</div><div>===================================================================</div><div>RCS \
file: /cvsroot/nagios/nagios/base/logging.c,v</div><div>retrieving revision \
1.41</div><div>
diff -r1.41 logging.c</div><div>395c395</div><div>< <span class="Apple-tab-span" \
style="white-space:pre"> </span>t=localtime(&rotation_time);</div><div>---</div><div>> \
<span class="Apple-tab-span" \
style="white-space:pre"> </span>t=gmtime(&rotation_time);<span \
class="Apple-tab-span" style="white-space:pre"> </span>/* see \
t-tap/var/nagios.log.expected, and a note near t-tap/test_logging.c@81 look for \
"base/logging.c@395" */</div> <div>cvs diff: Diffing t-tap</div><div>Index: \
t-tap/test_logging.c</div><div>===================================================================</div><div>RCS \
file: /cvsroot/nagios/nagios/t-tap/test_logging.c,v</div><div> retrieving revision \
1.2</div><div>diff -r1.2 test_logging.c</div><div>79a80,88</div><div>> <span \
class="Apple-tab-span" style="white-space:pre"> </span>/*</div><div>> <span \
class="Apple-tab-span" style="white-space:pre"> </span> * this was UTC+1 or BST \
timezone working with base/logging.c@395: t=localtime(&rotation_time)</div> \
<div>> <span class="Apple-tab-span" style="white-space:pre"> </span> * - not an \
error until they have to coincide. Problem is, this isn't an error so long as \
the</div><div>> <span class="Apple-tab-span" style="white-space:pre"> </span> * \
Nagios server never changes timezones because the log files will always be created \
in</div> <div>> <span class="Apple-tab-span" style="white-space:pre"> </span> * \
local timezone, and rotated on local time. In effect, by putting an epoch-based \
time</div><div>> <span class="Apple-tab-span" style="white-space:pre"> </span> * \
here, you're effectively requiring that all tinderbox servers be in the same \
timezone. </div> <div>> <span class="Apple-tab-span" \
style="white-space:pre"> </span> * Switching to gmtime effectively neutralizes, but \
puts everyone in UTC, which is an</div><div>> <span class="Apple-tab-span" \
style="white-space:pre"> </span> * hour off. Adjusting the epoch to match.</div> \
<div>> <span class="Apple-tab-span" style="white-space:pre"> </span> \
*</div><div>80a90,91</div><div>> <span class="Apple-tab-span" \
style="white-space:pre"> </span> */</div><div>> <span class="Apple-tab-span" \
style="white-space:pre"> </span>rotation_time = (time_t)1242953298;<span \
class="Apple-tab-span" style="white-space:pre"> </span>/* + 3600 , \
t-tap/var/nagios.log.expected altered to match */</div> <div>cvs diff: Diffing \
t-tap/var</div><div>Index: \
t-tap/var/nagios.log.expected</div><div>===================================================================</div><div>RCS \
file: /cvsroot/nagios/nagios/t-tap/var/nagios.log.expected,v</div> <div>retrieving \
revision 1.1</div><div>diff -r1.1 nagios.log.expected</div><div>1c1</div><div>< \
[1242949698] LOG ROTATION: HOURLY</div><div>---</div><div>> [1242953298] LOG \
ROTATION: HOURLY</div><div>3c3</div><div>< [1242949698] LOG VERSION: 2.0</div> \
<div>---</div><div>> [1242953298] LOG VERSION: \
2.0</div><div><br></div></div></div></div>-- <br><a \
href="mailto:allanc@chickenandporn.com">allanc@chickenandporn.com</a> \
"金鱼" <a \
href="http://tech.chickenandporn.com/tags/nagios/">http://tech.chickenandporn.com/tags/nagios/</a>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Nagios-devel mailing list
Nagios-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic