[prev in list] [next in list] [prev in thread] [next in thread] 

List:       nagios-devel
Subject:    Re: [Nagios-devel] Daylight Savings CGI bug
From:       Ethan Galstad <egalstad () nagios ! org>
Date:       2009-07-03 16:11:58
Message-ID: 4A4E2DCE.20901 () nagios ! org
[Download RAW message or body]


Mark Goldfinch wrote:
> Greetings all,
> 
> I've discovered a Daylight Savings Time bug within the avail, histogram, summary \
> and trends CGIs. 
> To reproduce, run a custom report timeperiod for a duration which spans migration \
> into or out of DST.  As an example using NZST either 1st Apr to 30th Apr or 1st Sep \
> to 30th Sep.  Note the start and end time, either the start or end time will be an \
> hour out from what one would expect. 
> Please see the attached patch to fix.  The problem arises from using the generated \
> tm_isdst flag from calling localtime(&current_time) within compute_report_times().  \
> It should be noted setting tm_isdst=-1 is used elsewhere within these CGIs already. \
>  Thanks,
> 


Fixed in CVS.  Thanks.


- Ethan Galstad

------------------------------------------------------------------------------
_______________________________________________
Nagios-devel mailing list
Nagios-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nagios-devel


[prev in list] [next in list] [prev in thread] [next in thread]