[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mythtv-dev
Subject:    Re: [mythtv] Ticket #4516: Fix broken Win32
From:       Nigel Pearson <nigel () ind ! tansu ! com ! au>
Date:       2008-01-31 3:42:51
Message-ID: 305FFB9E-2ED2-4B01-B11D-6F3E128366ED () ind ! tansu ! com ! au
[Download RAW message or body]


> When you have time, take a look at http://svn.mythtv.org/trac/ 
> ticket/4546 -
> why not something like this?

Several thoughts:


1) If we go this way, it should probably
be in a C++ style wrapper. e.g.

class MythContext {
...
   public:
...
     static MythContext *get(void);
     CreateMythContext(const QString &binversion);
...
}


2) I like the tidyup of the gContext lines in */main.cpp


3) Having global variables isn't intrinsically evil.
If anything, it makes the code a little bit tidier:
    gContext->blah()
instead of
    GetMythContext()->blah()
or
    MythContext::get()->blah()


4) There are MythContext reorgs planned to
work around the circular deps problem. See

http://svn.mythtv.org/trac/ticket/4264

While that has its own problems, I'm hoping
that long-term, it will be a better solution.
>

--
Nigel Pearson, nigel@ind.tansu.com.au|The weak point of
Telstra Net. Eng., Sydney, Australia | the modern car is
Office: 9202 3900    Fax:  9261 3912 | the squidgy organic
Mobile: 0408 664435  Home: 9792 6998 | bit behind the wheel.
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

[prev in list] [next in list] [prev in thread] [next in thread]