[prev in list] [next in list] [prev in thread] [next in thread] 

List:       myfaces-dev
Subject:    RE: [jira] Commented: (MYFACES-769) configurable IDs used for rendering
From:       "Stan Silvert" <stan.silvert () jboss ! com>
Date:       2006-02-28 15:54:30
Message-ID: C2CDEFBECFC9A14892BCCFB4C95F486804A22F03 () EX-201 ! mail ! navisite ! com
[Download RAW message or body]

+1 

Jacob is right.  PortletExternalContextImpl was changed to append
(instead of prepend) the portlet namespace.  This broke the spec as far
as javadoc is concerned.

Before the change to PortletExternalContextImpl, we were potentially
breaking section 3.1.1 of the spec because we had no control over the
naming of the portlet namespace.

Jacob's solution fixes both concerns.  Without objection, I plan to
commit his solution as soon as Sean is done with the refactoring.

This should address both of these:
https://issues.apache.org/jira/browse/MYFACES-1154
https://issues.apache.org/jira/browse/MYFACES-769

Stan Silvert
JBoss, Inc.
ssilvert@jboss.com
callto://stansilvert

> -----Original Message-----
> From: jacob@hookom.net [mailto:jacob@hookom.net]
> Sent: Tuesday, February 28, 2006 10:31 AM
> To: dev@myfaces.apache.org; dev@myfaces.apache.org
> Subject: RE: [jira] Commented: (MYFACES-769) configurable IDs used for
> rendering
> 
> Why not change the logic to:
> UIViewRoot.createUniqueId() {
> return UNIQUE_ID +
extCtx.encodeNamepace(Integer.toString(_next_Id++));
> }
> 
> >    [
> >http://issues.apache.org/jira/browse/MYFACES-
> 769?page=comments#action_12368111
> >]
> >
> >Dave Brondsema commented on MYFACES-769:
> >----------------------------------------
> >
> >In other words:  My <h:form> is my parent-most naming container.  I
need
> its
> >ID to be namespace-encoded since this portlet is used multiple times
on
> the
> >same portal page.  Can I specify an id="foo" on the form and have
that be
> >namespace encoded?  Or must the h:form use a dynamic id?
> >
> >> configurable IDs used for rendering
> >> -----------------------------------
> >>
> >>          Key: MYFACES-769
> >>          URL: http://issues.apache.org/jira/browse/MYFACES-769
> >>      Project: MyFaces Core
> >>         Type: Improvement
> >>     Reporter: Dave Brondsema
> >>     Assignee: Martin Marinschek
> >
> >>
> >> If the same code is used ot generated a component tree for more
than
> one
> >part of a webpage, the rendered IDs are the same and functionality is
> broken
> >(javascript needs unique IDs).
> >> An example of when this happens is when as portlet uses JSF for
> rendering.
> >If the portlet is used more than once on a single page (e.g. an RSS
> reader)
> >all the IDs are the same.
> >> Thus we need a way to have more configurable (perhaps random) IDs
when
> >rendered.
> >
> >--
> >This message is automatically generated by JIRA.
> >-
> >If you think it was sent incorrectly contact one of the
administrators:
> >   http://issues.apache.org/jira/secure/Administrators.jspa
> >-
> >For more information on JIRA, see:
> >   http://www.atlassian.com/software/jira
> >

[prev in list] [next in list] [prev in thread] [next in thread]