[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mutt-dev
Subject:    Re: patch-1.1.2.me.inline.1
From:       Thomas Roessler <roessler () guug ! de>
Date:       2000-01-29 8:03:01
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 2000-01-28 15:16:19 -0800, Michael Elkins wrote:

> In addition, I added a %I sequence for the $attach_format to
> display the disposition of a body part (1 char, either I or A),
> and a new command toggle-disposition (default: ^D) in the compose
> menu to alter the value for a part.

Playing around with this, I think the attached changes should
additionally be made.  Otherwise, mutt will tell the user that all
of the untagged attachments are considered to have an "attachment"
disposition, and not "inline" - although the latter is how mutt
(correctly) handles these attachments.

Note, BTW, that even Outlook doesn't tag _all_ message parts.

Additionally, I've changed the attach_format default value to this:

      "%u%D%I %t%4n %T%.40d%>  [%.7m/%.10M, %.6e%?C?, %C?, %s] "

--=20
http://www.guug.de/~roessler/

["patch-1.1.2.tlr.inline.1-2" (text/plain)]

Index: parse.c
===================================================================
RCS file: /home/roessler/cvsroot/mutt/parse.c,v
retrieving revision 2.22
diff -u -p -u -r2.22 parse.c
--- parse.c	2000/01/10 10:35:49	2.22
+++ parse.c	2000/01/29 07:54:35
@@ -370,11 +370,12 @@ BODY *mutt_read_mime_header (FILE *fp, i
   char *line = safe_malloc (LONG_STRING);
   size_t linelen = LONG_STRING;
   
-  p->hdr_offset = ftell(fp);
+  p->hdr_offset  = ftell(fp);
 
-  p->encoding = ENC7BIT; /* default from RFC1521 */
-  p->type = digest ? TYPEMESSAGE : TYPETEXT;
-
+  p->encoding    = ENC7BIT; /* default from RFC1521 */
+  p->type        = digest ? TYPEMESSAGE : TYPETEXT;
+  p->disposition = DISPINLINE;
+  
   while (*(line = read_rfc822_line (fp, line, &linelen)) != 0)
   {
     /* Find the value of the current header */
@@ -887,10 +888,13 @@ ENVELOPE *mutt_read_rfc822_header (FILE 
       hdr->content = mutt_new_body ();
 
       /* set the defaults from RFC1521 */
-      hdr->content->type = TYPETEXT;
-      hdr->content->subtype = safe_strdup ("plain");
-      hdr->content->encoding = ENC7BIT;
-      hdr->content->length = -1;
+      hdr->content->type        = TYPETEXT;
+      hdr->content->subtype     = safe_strdup ("plain");
+      hdr->content->encoding    = ENC7BIT;
+      hdr->content->length      = -1;
+
+      /* RFC 2183 says this is arbitrary */
+      hdr->content->disposition = DISPINLINE;
     }
   }
 

[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]