[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mutt-dev
Subject:    Re: [Mutt] #2807: pager.c remembers TopLine when it shouldn't
From:       Mutt <fleas () mutt ! org>
Date:       2017-10-18 8:03:52
Message-ID: 069.8c003f041bed254727e702a357d8e98d () mutt ! org
[Download RAW message or body]

#2807: pager.c remembers TopLine when it shouldn't
----------------------+----------------------
  Reporter:  tamo@…   |      Owner:  mutt-dev
      Type:  defect   |     Status:  closed
  Priority:  minor    |  Milestone:  2.0
 Component:  display  |    Version:  1.5.14
Resolution:  fixed    |   Keywords:  #2118
----------------------+----------------------
Changes (by kevin8t8):

 * status:  new => closed
 * resolution:   => fixed


Old description:

> {{{
> Since this change (http://mutt.kublai.com/hg/cvs/rev/b894fd4c9032)
> on Sep 08 2005, the builtin pager keeps its position
> even on OP_MAIN_NEXT_UNDELETED. So you cannot re-read
> the last message from the top of it with <space>.
> (See How-To-Repeat)
>
> This must be a side-effect of http://bugs.mutt.org/1210
>
> >How-To-Repeat:
> 1. :unset pager_stop
> 2. <change-folder> to a folder which has a long (more
>  than a screen-length) message as the last entry.
> 3. Hit <space> on the last message.
> 4. Repeat <space> until the message finishes.
> 5. You will be in index mode (because the message
>  is the last entry in the folder).
> 6. Hit <space> again. You will see the _bottom_ of
>  the message, not the top.
>
> >Fix:
> Forget TopLine when <next-page> (with $pager_stop)
> causes OP_MAIN_NEXT_UNDELETED.
> (though Brendan called it "a bogus detection")
> }}}

New description:

 {{{
 Since this change (http://mutt.kublai.com/hg/cvs/rev/b894fd4c9032)
 on Sep 08 2005, the builtin pager keeps its position
 even on OP_MAIN_NEXT_UNDELETED. So you cannot re-read
 the last message from the top of it with <space>.
 (See How-To-Repeat)

 This must be a side-effect of http://bugs.mutt.org/1210

 >How-To-Repeat:
 1. :unset pager_stop
 2. <change-folder> to a folder which has a long (more
  than a screen-length) message as the last entry.
 3. Hit <space> on the last message.
 4. Repeat <space> until the message finishes.
 5. You will be in index mode (because the message
  is the last entry in the folder).
 6. Hit <space> again. You will see the _bottom_ of
  the message, not the top.

 >Fix:
 Forget TopLine when <next-page> (with $pager_stop)
 causes OP_MAIN_NEXT_UNDELETED.
 (though Brendan called it "a bogus detection")
 }}}

--

Comment:

 I believe these issues were fixed in changeset:7abc19ad2d10 and
 changeset:ca8a3451b707

--
Ticket URL: <https://dev.mutt.org/trac/ticket/2807#comment:5>
Mutt <http://www.mutt.org/>
The Mutt mail user agent

[prev in list] [next in list] [prev in thread] [next in thread]