[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mutt-dev
Subject:    mutt: Don't filter new entries when compacting history save file.
From:       Brendan Cully <brendan () kublai ! com>
Date:       2017-05-13 16:53:17
Message-ID: hg.4bffaa6d189a.1494694397.1928362535899276112 () dev ! cs ! ubc ! ca
[Download RAW message or body]

changeset: 7046:4bffaa6d189a
user:      Kevin McCarthy <kevin@8t8.us>
date:      Sat May 13 09:48:28 2017 -0700
link:      http://dev.mutt.org/hg/mutt/rev/4bffaa6d189a

Don't filter new entries when compacting history save file.

If new entries are added between the two passes, they won't be in the
dup_hash.  The original intent was to filter added duplicates, but the
check would also filter brand new entries.

diffs (12 lines):

diff -r 7a4cc1750940 -r 4bffaa6d189a history.c
--- a/history.c	Fri May 12 18:31:41 2017 -0700
+++ b/history.c	Sat May 13 09:48:28 2017 -0700
@@ -244,7 +244,7 @@
 	continue;
       *p = '\0';
       if (option (OPTHISTREMOVEDUPS) &&
-          (dup_hash_dec (dup_hashes[hclass], linebuf + read) != 0))
+          (dup_hash_dec (dup_hashes[hclass], linebuf + read) > 0))
         continue;
       *p = '|';
       if (n[hclass]-- <= SaveHist)
[prev in list] [next in list] [prev in thread] [next in thread]