[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mutt-dev
Subject:    Re: [PATCH 1 of 2] Use proper prototype for
From:       "Matthias Andree" <matthias.andree () gmx ! de>
Date:       2009-07-27 11:15:15
Message-ID: op.uxp37ph61e62zd () balu ! cs ! uni-paderborn ! de
[Download RAW message or body]

Am 23.07.2009, 23:55 Uhr, schrieb Matthias Andree <matthias.andree@gmx.de>:

> # HG changeset patch
> # User Matthias Andree <matthias.andree@gmx.de>
> # Date 1248385890 -7200
> # Branch HEAD
> # Node ID 02a82e1ae8cbfaae70e10554198441c150ba1648
> # Parent  713a18794bb777570935780758e6a3e963116e61
> Use proper prototype for mutt_get_default_charset(), fix fallout.
>
...
> diff -r 713a18794bb7 -r 02a82e1ae8cb rfc2047.c
> --- a/rfc2047.c	Wed Jul 08 00:46:56 2009 +0200
> +++ b/rfc2047.c	Thu Jul 23 23:51:30 2009 +0200
> @@ -119,7 +119,7 @@
>      }
>    }
>    mutt_convert_string (ps,
> -      (const char *)mutt_get_default_charset (AssumedCharset),
> +      (const char *)mutt_get_default_charset (),
>        Charset, M_ICONV_HOOK_FROM);
>    return -1;
>  }

Hmmm... after a weekend away from computers, I now wonder what the  
intended purpose of AssumedCharset used to be. Was someone trying to  
propagate configuration or default or fallback values here? If so, such  
code may need to be written. I don't oversee the purposes here, I only  
fixed the obvious case, that means: if mutt_get_default_charset doesn't  
expect its argument, it cannot use it, so we just stop passing it. This  
was without further code of the intention. Is this a remainder from  
editing things or was it a hint to different intentions that just didn't  
work the way they were written?

-- 
Matthias Andree
[prev in list] [next in list] [prev in thread] [next in thread]