[prev in list] [next in list] [prev in thread] [next in thread] 

List:       musl
Subject:    Re: [musl] [PATCH 01/18] clock_gettime: prefer time64 variant if available
From:       Rich Felker <dalias () aerifal ! cx>
Date:       2020-12-27 21:54:21
Message-ID: 20201227215421.GB22981 () brightrain ! aerifal ! cx
[Download RAW message or body]

On Sun, Dec 27, 2020 at 06:40:45PM +0000, Alexander Lobakin wrote:
> Instead of using time64 variant "only when needed", use it as
> a default and fallback to time32 only on -ENOSYS.
> 
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>  src/time/clock_gettime.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/time/clock_gettime.c b/src/time/clock_gettime.c
> index 3e1d0975b122..ec8d08c010cf 100644
> --- a/src/time/clock_gettime.c
> +++ b/src/time/clock_gettime.c
> @@ -73,9 +73,7 @@ int __clock_gettime(clockid_t clk, struct timespec *ts)
>  #endif
>  
>  #ifdef SYS_clock_gettime64
> -	r = -ENOSYS;
> -	if (sizeof(time_t) > 4)
> -		r = __syscall(SYS_clock_gettime64, clk, ts);
> +	r = __syscall(SYS_clock_gettime64, clk, ts);
>  	if (SYS_clock_gettime == SYS_clock_gettime64 || r!=-ENOSYS)
>  		return __syscall_ret(r);
>  	long ts32[2];
> -- 
> 2.29.2

This change is a functional nop, just removing code that's left from
prior to the time64 switchover. It's probably not objectionable, but
it's not described accurately.

Rich
[prev in list] [next in list] [prev in thread] [next in thread]