[prev in list] [next in list] [prev in thread] [next in thread]
List: musl
Subject: Re: [musl] clarify bswap a bit more for gcc
From: Pascal Cuoq <cuoq () trust-in-soft ! com>
Date: 2019-03-24 14:31:02
Message-ID: 3B6039DA-8A3A-4E04-B7DD-43A5049E1698 () trust-in-soft ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
On 24 Mar 2019, at 12:26, vilimp@volny.cz<mailto:vilimp@volny.cz> wrote:
i know nearly nothing about programing, but is it possible to upstream this
patch, please? It gets rid of gcc's warnings.
If you search around for discussion about this GCC warning, you will find a lot of \
opinions such as
"That's the one warning that I like to disable. I hate having to write superfluous \
parentheses around conjunctions. I mean, come on. It's just as lame as requiring them \
around multiplications would be." https://news.ycombinator.com/item?id=15405045
"Fortunately I live by my own rule, to avoid unnecessary parentheses" \
http://wordaligned.org/articles/fixing-compiler-warnings-the-hard-way
There is no reason to think that people in the position of making this change have \
not already compiled musl with GCC, seen the warning and decided it wasn't useful. Do \
"git grep parentheses" in musl and you'll find:
configure:tryflag CFLAGS_AUTO -Wno-parentheses
Whatever you did to compile musl, if I were you I would just try to find how to do it \
in in a way that does not activate this warning.
Pascal
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: \
after-white-space;" class=""> <br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 24 Mar 2019, at 12:26, <a href="mailto:vilimp@volny.cz" class="">
vilimp@volny.cz</a> wrote:</div>
<div class="">
<div class=""><br class="">
i know nearly nothing about programing, but is it possible to upstream this<br \
class=""> patch, please? It gets rid of gcc's warnings.<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
<div class="">If you search around for discussion about this GCC warning, you will \
find a lot of opinions such as</div> <div class=""><br class="">
</div>
<div class="">"That's the one warning that I like to disable. I hate having to write \
superfluous parentheses around conjunctions. I mean, come on. It's just as lame \
as requiring them around multiplications would be." <a \
href="https://news.ycombinator.com/item?id=15405045" \
class="">https://news.ycombinator.com/item?id=15405045</a></div> <div class=""><br \
class=""> </div>
<div class="">"Fortunately I live by my own rule, to avoid unnecessary \
parentheses" <a \
href="http://wordaligned.org/articles/fixing-compiler-warnings-the-hard-way" \
class="">http://wordaligned.org/articles/fixing-compiler-warnings-the-hard-way</a></div>
<div class=""><br class="">
</div>
<div class="">There is no reason to think that people in the position of making this \
change have not already compiled musl with GCC, seen the warning and decided it \
wasn't useful. Do "git grep parentheses" in musl and you'll find:</div> <div \
class=""><br class=""> </div>
<div class="">configure:tryflag CFLAGS_AUTO -Wno-parentheses<br class="">
</div>
<div class=""><br class="">
</div>
<div class="">Whatever you did to compile musl, if I were you I would just try to \
find how to do it in in a way that does not activate this warning.</div> <div \
class=""><br class=""> </div>
<div class="">Pascal</div>
<div class=""><br class="">
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic