[prev in list] [next in list] [prev in thread] [next in thread] 

List:       musl
Subject:    Re: [musl] Header conformance/improvements
From:       Daniel Sabogal <dsabogalcc () gmail ! com>
Date:       2016-10-20 23:19:50
Message-ID: CAFhhQJQu4o++-U2ocFC5i24rgPMsstOUx7SBPKRUK61gDY-5Aw () mail ! gmail ! com
[Download RAW message or body]

On Thu, Oct 20, 2016 at 5:30 PM, Rich Felker <dalias@libc.org> wrote:
> On Tue, Oct 11, 2016 at 06:44:14PM -0400, Daniel Sabogal wrote:
>> namespace/feature testing
>> -------------------------
>> sys/time.h:13-29: sys/time.h - XSI header
>
> Not sure what you mean here. If the whole header is XSI there's no
> obligation to check FTMs; a conforming non-XSI program doesn't include
> it.

Sorry, I should have been more descriptive with this one. The issue here is
that there are unnecessary checks for _XOPEN_SOURCE.

>> misc
>> ----
>> stdlib.h:155-8:
>> glibc provides locale_t under _GNU_SOURCE. maybe it should
>> be provided and used in place of struct __locale_struct.
>
> Do you have in mind a scenario where this would be useful, i.e. where
> you might need locale_t to be defined but not have included another
> header that defines it?

I was really only thinking along the lines of keeping it consistent with
how all other headers provide locale_t via __NEED_locale_t.
I don't believe there are any real benefits and that any software package
already doing this should be easily patch-able.

>> string.h:88:
>> gcc generates an implicit-function-declaration warning from alloca
>> when using strdupa. aside: glibc also provides strndupa.
>
> We discussed making this definition depend on __GNUC__ and then it
> could use __builtin_alloca and GCC extensions needed to make strndupa
> work. There might be an old patch floating around to do something like
> that.

OK.
[prev in list] [next in list] [prev in thread] [next in thread]