[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mplayer-dev-eng
Subject:    Re: [MPlayer-dev-eng] [PATCH] --target=alpha_ev5-linux
From:       Diego Biurrun <diego () biurrun ! de>
Date:       2007-10-22 16:00:20
Message-ID: 20071022160020.GH2042 () biurrun ! de
[Download RAW message or body]

On Mon, Oct 08, 2007 at 02:39:12PM +0200, Diego Biurrun wrote:
> On Sat, Oct 06, 2007 at 04:49:35PM +0200, A Mennucc wrote:
> > Dominik 'Rathann' Mierzejewski ha scritto:
> > > On Saturday, 06 October 2007 at 15:16, A Mennucc wrote:
> > > [...]
> > >>>>  int main() {
> > >>>>      unsigned long ver, mask;
> > >>>> @@ -2142,9 +2149,8 @@
> > >>> Cosmetics.
> > >> yes; just reindented to represent code block
> > >>
> > >> the "real code" is just  3 lines
> > > [...]
> > > 
> > > I still think that the cosmetic indentation fix below
> > > should be in a separate patch. Without it, the whole hunk
> > > would consist of only adding "fi".
> > 
> > here is the code-only patch
> 
> This patch contains two unrelated changes.
> 
> > --- configure	(revisione 24712)
> > +++ configure	(copia locale)
> > @@ -146,7 +146,7 @@
> >  
> >  alpha() {
> >    case "$host_arch" in
> > -    alpha) return 0;;
> > +    alpha*) return 0;;
> 
> Why?
> 
> > @@ -1257,7 +1257,7 @@
> >          fi
> >        ;;
> >        macppc|ppc|ppc64) host_arch=ppc ;;
> > -      alpha) host_arch=alpha ;;
> > +      alpha*) host_arch=alpha ;;
> >        sparc) host_arch=sparc ;;
> >        sparc64) host_arch=sparc64 ;;
> >        parisc*|hppa*|9000*) host_arch=hppa ;;
> > @@ -2126,13 +2126,19 @@
> >  
> >      ;;
> >  
> > -  alpha)
> > +  alpha*)
> 
> This is redundant after the change above.

Andrea, will you send in an updated patch please?

Diego
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@mplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
[prev in list] [next in list] [prev in thread] [next in thread]