[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mplayer-dev-eng
Subject:    Re: [MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work
From:       "Zuxy Meng" <zuxy.meng () gmail ! com>
Date:       2007-05-30 8:34:55
Message-ID: a18e06b40705300134of17fe9fr53006d0f5578c1ca () mail ! gmail ! com
[Download RAW message or body]

Hi,

2007/5/28, Zuxy Meng <zuxy.meng@gmail.com>:
> Hi,
>
> 2007/5/28, Reimar Döffinger <Reimar.Doeffinger@stud.uni-karlsruhe.de>:
> > Hello,
> > On Mon, May 28, 2007 at 09:57:14AM +0800, Zuxy Meng wrote:
> > > 2007/5/26, Zuxy Meng <zuxy.meng@gmail.com>:
> > > > I've tested the patch on IA-32 and AMD64 (thanks to Stefan's testbed!)
> > > > and no regression has been found.
> > >
> > > Would u help review the new patch, Reimar?
> >
> > While I am not entirely convinced that all of it is necessary the patch
> > seems okay to me.
> > Except maybe that you use once *(unsigned*)hbuf and once
> > *(uint32_t*)hbuf, I'd consider using the same in both cases.
>
> Will be corrected. Is the rest OK to apply?

Will apply this weekend if no one disagrees.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@mplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

[prev in list] [next in list] [prev in thread] [next in thread]