[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mplayer-dev-eng
Subject:    [MPlayer-dev-eng] [PATCH] ao_oss.c: Re-Open device on pause with
From:       Fabian Franz <FabianFranz () gmx ! de>
Date:       2006-09-25 15:26:50
Message-ID: 200609251727.02124.FabianFranz () gmx ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi,

MPlayer does not re-open the oss device with O_NONBLOCK. The patch fixes that.

This bug has been there since 2002. Why now that patch?

Well, I've written a blocking implementation of esddsp and I just can't tell 
that the output should be non-blocking if this flag is not set ...

And there might be even soundcards out there having the same problem ...

cu

Fabian

-- 
      *** Consulting - Training - Workshops - Troubleshooting ***
   @@@ LiveCDs (Knoppix), Debian, Remote Desktop Access (FreeNX) @@@

--- Fabian Franz --- www.fabian-franz.de --- consulting@fabian-franz.de

["ao_oss-fix-nonblock-on-pause.diff" (text/x-diff)]

--- ao_oss.c.old	2006-09-25 06:40:19.000000000 +0200
+++ ao_oss.c	2006-09-25 06:41:06.000000000 +0200
@@ -426,7 +426,12 @@
 static void reset(void){
   int oss_format;
     uninit(1);
+#ifdef __linux__
+    audio_fd=open(dsp, O_WRONLY | O_NONBLOCK);
+#else
     audio_fd=open(dsp, O_WRONLY);
+#endif
+
     if(audio_fd < 0){
 	mp_msg(MSGT_AO,MSGL_ERR,MSGTR_AO_OSS_CantReopen, strerror(errno));
 	return;

[Attachment #8 (application/pgp-signature)]

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@mplayerhq.hu
http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

[prev in list] [next in list] [prev in thread] [next in thread]