[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mplayer-dev-eng
Subject:    Re: [MPlayer-dev-eng] [PATCH] Remove auto-inserted lavc if vd init
From:       Jindrich Makovicka <makovick () kmlinux ! fjfi ! cvut ! cz>
Date:       2005-02-27 9:58:21
Message-ID: 422199BD.1020008 () kmlinux ! fjfi ! cvut ! cz
[Download RAW message or body]

Reimar Döffinger wrote:
> Hi,
> On Sun, Feb 27, 2005 at 01:05:29AM -0600, Zoltan Hidvegi wrote:
> 
>>The attached patch removes the auto-inserted lavc if
>>mpcodecs_config_vo fails.
> 
> 
> IMHO the whole code needs to be reworked, e.g. it also select Y800
> output format (grayscale) if that is the only YUV format supported in
> hardware, and a lot more stupidities. Unfortunately this code is
> duplicated somewhere (I think vf.c), so there are two places that are in
> need of a fix :-(

Yes, similar code (but not 100% identical) is in vf_next_config. It 
would be nice to merge the common parts in one function somehow.

> I attached the patch I created back then, but it is no perfect and
> doesn't fix your problem (yet).
> If you have the time, please try to find a really good fix *g*

-- 
Jindrich Makovicka

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng@mplayerhq.hu
http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
[prev in list] [next in list] [prev in thread] [next in thread]