[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mplayer-dev-eng
Subject:    Re: [MPlayer-dev-eng] [PATCH] Fullscreen fix for openbox, fvwm and afterstep
From:       Arpi <arpi () thot ! banki ! hu>
Date:       2002-12-31 0:06:18
Message-ID: 200212310006.gBV06IbV004135 () mail ! mplayerhq ! hu
[Download RAW message or body]

Hi,

> This time the patch is fixing much more that breaking :-)
> It includes ugly hack for OpenBox, swaps checking for netwm
> with layers (and makes fvwm work -> they have also broken
> _NET_WM_STATE_FULLSCREEN but also supports layers) and changes
> back fullscreen layer to 10, afterstep doesn't like 12 :-)
> 
> Tested with: sawfish, metacity, kwin, blackbox, openbox, waimea,
> windowmaker, afterstep, icewm, mwm, fvwm

great! commited...

btw i'm keep testing with mwm (motif wm, the last commercial version)
(it's a very tricky one, Pontscho hacked x11_common a lot to get it fixed :)
and it's still working :)
also i've tried (OLD) enlightenment, gnome (probably 1.2.x), kde 2.x, wmaker
(also old) and xfce (not so old). (they are old as they come from slackware
8.0 (~1 year old release)). they all worked.

the only non-working "wm" was twm :)
it was funny, it even expected to click to the window (to "place" it on the
screen) whenever i pressed 'f' :)
but i hope that no one uses twm nowdays :)

> P.S
> Another reason to change option name "-icelayer" to "-fslayer"
> are fvwm and afterstep, they also use layers.

yes i know.
the reason of i didn't commited that part is making testing of different
versions of x11_common.c (to find which commit broke something) easy for now.

maybe we should rename the option but keep the name of the variable for now
(maybe rename later in a cleanup phase), so x11_common.c versions will
remain compatible.

actually i don't feel this renaming so important...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu

[prev in list] [next in list] [prev in thread] [next in thread]