[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mozilla-layout
Subject:    Re: Slow code in nsContainerFrame
From:       Steve Clark <buster () netscape ! com>
Date:       2000-01-25 18:27:15
[Download RAW message or body]

hey shaver:

looks like you're on the right track. As far as I know, key events go to
focused frame, period.  Is it ever possible to have a state where no frame
has the focus?  I would think there'd always be a default of the root frame
or something like that.  hyatt or saari would know for sure, or maybe joki.

steve

Mike Shaver wrote:

> From nsPresShell::HandleEvent, I give you:
>
>        if (NS_IS_KEY_EVENT(aEvent)) {
>         //Key events go to the focused frame, not point based.
>         manager->GetFocusedContent(&focusContent);
>         if (focusContent)
>           GetPrimaryFrameFor(focusContent, &mCurrentEventFrame);
>         else frame->GetFrameForPoint(mPresContext, aEvent->point,
> &mCurrentEventFrame);
>
> If there's nothing focused, why are we looking for the FrameForPoint of
> (0,0)?  Should we not either drop the event on the floor -- without
> focus, nobody can recieve key events, right? -- or use the frame from
> clientData, or give it to a default handler, or something?
>
> Cc:ing joki, hyatt and troy, who look like the last people to touch that
> code.
>
> Mike
>
> --
> 174015.35 166304.97

[prev in list] [next in list] [prev in thread] [next in thread]