[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mono-patches
Subject:    [Mono-patches] r150606 -
From:       "Zoltan Varga (vargaz AT gmail.com)" <mono-patches-list () lists ! ximian ! com>
Date:       2010-01-31 19:19:12
Message-ID: 20100131191912.6D7099472C () mono-cvs ! ximian ! com
[Download RAW message or body]

Author: zoltan
Date: 2010-01-31 14:19:12 -0500 (Sun, 31 Jan 2010)
New Revision: 150606

Modified:
   branches/mono-2-6/mcs/class/corlib/System.IO/ChangeLog
   branches/mono-2-6/mcs/class/corlib/System.IO/Directory.cs
Log:
2010-01-31  Zoltan Varga  <vargaz@gmail.com>

	* Directory.cs (Exists): Never throw an exception. Fixes #565152.

Modified: branches/mono-2-6/mcs/class/corlib/System.IO/ChangeLog
===================================================================
--- branches/mono-2-6/mcs/class/corlib/System.IO/ChangeLog	2010-01-31 19:17:34 UTC (rev 150605)
+++ branches/mono-2-6/mcs/class/corlib/System.IO/ChangeLog	2010-01-31 19:19:12 UTC (rev 150606)
@@ -1,3 +1,7 @@
+2010-01-31  Zoltan Varga  <vargaz@gmail.com>
+
+	* Directory.cs (Exists): Never throw an exception. Fixes #565152.
+
 2010-01-14  Rolf Bjarne Kvinge  <RKvinge@novell.com>
 
 	* UnmanagedMemoryStream.cs: Read: don't read bytes one-by-one, read all

Modified: branches/mono-2-6/mcs/class/corlib/System.IO/Directory.cs
===================================================================
--- branches/mono-2-6/mcs/class/corlib/System.IO/Directory.cs	2010-01-31 19:17:34 UTC (rev 150605)
+++ branches/mono-2-6/mcs/class/corlib/System.IO/Directory.cs	2010-01-31 19:19:12 UTC (rev 150606)
@@ -214,19 +214,8 @@
 			bool exists;
 			
 			exists = MonoIO.ExistsDirectory (path, out error);
-			if (error != MonoIOError.ERROR_SUCCESS &&
-			    error != MonoIOError.ERROR_PATH_NOT_FOUND &&
-			    error != MonoIOError.ERROR_INVALID_HANDLE &&
-			    error != MonoIOError.ERROR_ACCESS_DENIED) {
-
-				// INVALID_HANDLE might happen if the file is moved
-				// while testing for the existence, a kernel issue
-				// according to Larry Ewing.
-				
-				throw MonoIO.GetException (path, error);
-			}
-
-			return(exists);
+			/* This should not throw exceptions */
+			return exists;
 		}
 
 		public static DateTime GetLastAccessTime (string path)

_______________________________________________
Mono-patches maillist  -  Mono-patches@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-patches
[prev in list] [next in list] [prev in thread] [next in thread]