[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mono-patches
Subject:    [Mono-patches] r120301 -
From:       "Sebastien Pouliot (sebastien () ximian ! com)"
Date:       2008-11-30 17:41:27
Message-ID: 20081130174127.116979472C () mono-cvs ! ximian ! com
[Download RAW message or body]

Author: spouliot
Date: 2008-11-30 12:41:26 -0500 (Sun, 30 Nov 2008)
New Revision: 120301

Modified:
   trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/AvoidMethodWithUnusedGenericTypeRule.cs
  trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/ChangeLog
   trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/PreferGenericsOverRefObjectRule.cs
 Log:
2008-11-30  Sebastien Pouliot  <sebastien@ximian.com>

	* AvoidMethodWithUnusedGenericTypeRule.cs: Use HasParameters.
	* PreferGenericsOverRefObjectRule.cs: Use HasGenericParameters.



Modified: trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/AvoidMethodWithUnusedGenericTypeRule.cs
 ===================================================================
--- trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/AvoidMethodWithUnusedGenericTypeRule.cs	2008-11-30 \
                17:05:08 UTC (rev 120300)
+++ trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/AvoidMethodWithUnusedGenericTypeRule.cs	2008-11-30 \
17:41:26 UTC (rev 120301) @@ -108,7 +108,7 @@
 		public RuleResult CheckMethod (MethodDefinition method)
 		{
 			// rule applis only if the method has generic type parameters
-			if (method.GenericParameters.Count == 0)
+			if (!method.HasGenericParameters)
 				return RuleResult.DoesNotApply;
 
 			// look if every generic type parameter...

Modified: trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/ChangeLog
===================================================================
--- trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/ChangeLog	2008-11-30 \
                17:05:08 UTC (rev 120300)
+++ trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/ChangeLog	2008-11-30 \
17:41:26 UTC (rev 120301) @@ -1,3 +1,8 @@
+2008-11-30  Sebastien Pouliot  <sebastien@ximian.com>
+
+	* AvoidMethodWithUnusedGenericTypeRule.cs: Use HasParameters.
+	* PreferGenericsOverRefObjectRule.cs: Use HasGenericParameters.
+
 2008-11-07  Alan McGovern  <amcgovern@novell.com>
 
 	* Makefile.am:

Modified: trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/PreferGenericsOverRefObjectRule.cs
 ===================================================================
--- trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/PreferGenericsOverRefObjectRule.cs	2008-11-30 \
                17:05:08 UTC (rev 120300)
+++ trunk/mono-tools/gendarme/rules/Gendarme.Rules.Design.Generic/PreferGenericsOverRefObjectRule.cs	2008-11-30 \
17:41:26 UTC (rev 120301) @@ -82,7 +82,7 @@
 		public RuleResult CheckMethod (MethodDefinition method)
 		{
 			// rule does not apply to properties, events, without parameters or for generated \
                code
-			if (method.IsSpecialName || (method.Parameters.Count == 0) || \
method.IsGeneratedCode ()) +			if (method.IsSpecialName || !method.HasParameters || \
method.IsGeneratedCode ())  return RuleResult.DoesNotApply;
 
 			foreach (ParameterDefinition parameter in method.Parameters) {

_______________________________________________
Mono-patches maillist  -  Mono-patches@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-patches


[prev in list] [next in list] [prev in thread] [next in thread]