[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mono-osx
Subject:    Re: [Mono-osx] MonoMac: patch for NSPasteboard
From:       Duane Wandless <duane () wandless ! net>
Date:       2010-12-08 22:32:02
Message-ID: AANLkTino76FBNJwd4dJ6egFVko3KGPp=wX3i1CLwcweb () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Some of the names seem to be very un C#.  Like:

ReadObjectsForClassesoptions
AvailableTypeFromArray

And the pasteboard item types are defined as Fields like this:
NSStringPboardType
NSUrlPboardType

That would be nicer if it was just String or Url, etc.

It is small a class so I could make a pass at making it better if you'd
like.

Duane

On Wed, Dec 8, 2010 at 5:11 PM, Miguel de Icaza <miguel@novell.com> wrote:

> Thanks for the patch!
>
>
>> I did not C#-ify this class but it does need it.  Let me know and I'll do
>> a full pass on this class and send that as a new patch.
>>
>
> Got anything in mind for this?
>
> I did change the name of one of the static properties that really should
> have been a factory method.
>
> Miguel
>

[Attachment #5 (text/html)]

Some of the names seem to be very un C#.  \
Like:<div><br></div><div>ReadObjectsForClassesoptions</div><div>AvailableTypeFromArray</div><div><br></div><div>And \
the pasteboard item types are defined as Fields like this:</div> \
<div>NSStringPboardType</div><div>NSUrlPboardType</div><div><br></div><div>That would \
be nicer if it was just String or Url, etc.</div><div><br></div><div>It is small a \
class so I could make a pass at making it better if you&#39;d like.</div> \
<div><br></div><div>Duane<br><br><div class="gmail_quote">On Wed, Dec 8, 2010 at 5:11 \
PM, Miguel de Icaza <span dir="ltr">&lt;<a \
href="mailto:miguel@novell.com">miguel@novell.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="gmail_quote"><div>Thanks for the \
patch!</div><div class="im"><div> </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>I did not \
C#-ify this class but it does need it.  Let me know and I&#39;ll do a full pass on \
this class and send that as a new patch.</div>

</blockquote><div><br></div></div><div>Got anything in mind for \
this?</div><div><br></div><div>I did change the name of one of the static properties \
that really should have been a factory method.</div><div><br></div><font \
color="#888888"><div> Miguel</div>
</font></div>
</blockquote></div><br></div>



_______________________________________________
Mono-osx mailing list
Mono-osx@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-osx


[prev in list] [next in list] [prev in thread] [next in thread]