[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mono-devel-list
Subject:    Re: [Mono-dev] ReferenceSource of System.Text.UnicodeEncoding breaks System.Data.Odbc.OdbcDataReader
From:       Miguel de Icaza <miguel () xamarin ! com>
Date:       2015-05-10 1:15:37
Message-ID: CANqeOFqDvS1x5iuwBPGTRpHn=ZJ=dp=vZ_6mf2HnFxEnML1VQA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


We should get a fix, since we will be releasing bug fixes for the months to
come.

On Sat, May 9, 2015 at 6:57 PM, Markus Beth <markus.beth@zkrd.de> wrote:

> On 06.05.2015 02:58, Atsushi Eno wrote:
>
>> On 2015=E5=B9=B405=E6=9C=8805=E6=97=A5 01:29, Marek Safar wrote:
>>
>>> Hi,
>>>
>>>
>>>     We use the attached patch for Mono 4.0.1 which changes the
>>>     implementation of System.Data.Odbc.OdbcDataReader.GetColumn(int)
>>>     to make
>>>     it work with either implementation of
>>>     System.Text.UnicodeEncoding.GetString.
>>>
>>>
>>> Could you please send a pull request with the change?
>>>
>>>
>>>     Does it make sense to bring in patches like this or will
>>>     System.Data.Odbc be replaced by ReferenceSource in the (near) futur=
e?
>>>
>>>
>>> That's not very likely, reference sources code has quite few hard
>>> windows dependencies and I don't think we'll replace it or at least
>>> not very soon.
>>>
>>
>> Usually that's correct, but for System.Data.Odbc we use unixodbc that
>> PInvokes odbc32.dll compatible library. We already imported it.
>>
>
> OK, with commit 9f006cd1041c08ca6a048c039a3c57c187a1f453 I see that my
> patch (PR #1769) is no longer needed for branch master.
> Would it make sense to open a new PR for branch mono-4.0.0-branch? Or is
> this a waste of effort because there will be no new release from this
> branch?
>
> Markus
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>

[Attachment #5 (text/html)]

<div dir="ltr">We should get a fix, since we will be releasing bug fixes for the \
months to come.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, \
May 9, 2015 at 6:57 PM, Markus Beth <span dir="ltr">&lt;<a \
href="mailto:markus.beth@zkrd.de" target="_blank">markus.beth@zkrd.de</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span class="">On 06.05.2015 02:58, Atsushi Eno \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> On 2015年05月05日 01:29, Marek Safar wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi,<br>
<br>
<br>
      We use the attached patch for Mono 4.0.1 which changes the<br>
      implementation of System.Data.Odbc.OdbcDataReader.GetColumn(int)<br>
      to make<br>
      it work with either implementation of<br>
      System.Text.UnicodeEncoding.GetString.<br>
<br>
<br>
Could you please send a pull request with the change?<br>
<br>
<br>
      Does it make sense to bring in patches like this or will<br>
      System.Data.Odbc be replaced by ReferenceSource in the (near) future?<br>
<br>
<br>
That&#39;s not very likely, reference sources code has quite few hard<br>
windows dependencies and I don&#39;t think we&#39;ll replace it or at least<br>
not very soon.<br>
</blockquote>
<br>
Usually that&#39;s correct, but for System.Data.Odbc we use unixodbc that<br>
PInvokes odbc32.dll compatible library. We already imported it.<br>
</blockquote>
<br></span>
OK, with commit 9f006cd1041c08ca6a048c039a3c57c187a1f453 I see that my patch (PR \
#1769) is no longer needed for branch master.<br> Would it make sense to open a new \
PR for branch mono-4.0.0-branch? Or is this a waste of effort because there will be \
no new release from this branch?<span class="HOEnZb"><font color="#888888"><br> <br>
Markus</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
Mono-devel-list mailing list<br>
<a href="mailto:Mono-devel-list@lists.ximian.com" \
target="_blank">Mono-devel-list@lists.ximian.com</a><br> <a \
href="http://lists.ximian.com/mailman/listinfo/mono-devel-list" \
target="_blank">http://lists.ximian.com/mailman/listinfo/mono-devel-list</a><br> \
</div></div></blockquote></div><br></div>



_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


[prev in list] [next in list] [prev in thread] [next in thread]