[prev in list] [next in list] [prev in thread] [next in thread]
List: mono-devel-list
Subject: Re: [Mono-dev] [Mono-list] NUnit Version - Upgrade soon?
From: Atsushi Eno <atsushi () ximian ! com>
Date: 2008-11-25 8:06:09
Message-ID: 492BB1F1.2060001 () ximian ! com
[Download RAW message or body]
Actually it turned out to be my bogus Makefile that assumed
nunit-console-runner.dll is nunit-console.dll, which was conflicting
nunit-console.exe and hence type loading failure happened (and turned
out that it should fail since foo.dll and foo.exe cannot coexist).
Now I have a fixed version of nunit for our own use:
http://veritas-vos-liberabit.com/tmp/2008/nunit24-mono.tar.bz2
If no problem, I'll checkin this new nunit24 directory and build
changes, without removing nunit20 for a while.
Atsushi Eno
> It is anything but negative approach. As I wrote earlier, I believe this
> is a mono bug that likely hits other projects and should be fixed in
> mono land.
>
> I'll try to cook a repro and file a bug.
>
> For the record, there is almost no change in NUnit code in my archive.
> We just have to change AssemblyInfo (assembly key location), remove
> tests (they are extra in our source tree) and extra stuff such as GUI.
> It is straightforward upstream code. Believe or not, just diff them ;)
>
> Atsushi Eno
>
>
> Charlie Poole wrote:
>> I think a more positive approach would be to
>> work with the NUnit project so that you can
>> just use the upstream code.
>>
>> Charlie
>>
>>> -----Original Message-----
>>> From: mono-list-bounces@lists.ximian.com
>>> [mailto:mono-list-bounces@lists.ximian.com] On Behalf Of Atsushi Eno
>>> Sent: Saturday, November 22, 2008 4:30 PM
>>> To: mono-list@lists.ximian.com
>>> Subject: SPAM-LOW: Re: [Mono-list] NUnit Version - Upgrade soon?
>>>
>>> You almost do not have to do that:
>>> http://veritas-vos-liberabit.com/tmp/2008/nunit24-mono.tar.bz2
>>>
>>> It builds but does not work anyways right now, probably
>>> because of some type resolution bugs between
>>> nunit-console.dll and nunit-console.exe.
>>>
>>> If you have patch for mono (diff in mono/mcs, not diff in
>>> nunit) to fix any issues, that is welcome.
>>>
>>> Atsushi Eno
>>>
>>>
>>> Michael Franz wrote:
>>>> OK,
>>>>
>>>> I thought I read somewhere that there were patches to NUnit
>>> that were
>>>> mono specific.
>>>>
>>>> Is it ok to submit patches to mono that depend on the
>>> latest version
>>>> of NUnit?
>>>>
>>>> Michael
>>>>
>>>> On Tue, Nov 18, 2008 at 3:25 PM, Miguel de Icaza <miguel@novell.com
>>>> <mailto:miguel@novell.com>> wrote:
>>>>
>>>> Hello,
>>>>
>>>> > What changes to NUnit were specific to Mono?
>>>> >
>>>> > Is there a list of these features?
>>>>
>>>> You are confused; There are no changes, you should
>>> just not depend on
>>>> Mono's built-in and private copy of NUnit to write your
>>> NUnit test
>>>> cases.
>>>>
>>>> You should get the latest NUnit.
>>>>
>>>> > On Sun, Nov 16, 2008 at 10:54 PM, Miguel de Icaza
>>>> <miguel@novell.com <mailto:miguel@novell.com>>
>>>> > wrote:
>>>> > Hello,
>>>> >
>>>> >
>>>> > > I use NUnit for work and have been using
>>> the latest version
>>>> > for
>>>> > > months. I wrote some test for Mono and
>>> found out that the
>>>> > version
>>>> > > that Mono is using does not support some
>>> of the asserts
>>>> I am
>>>> > using
>>>> > > (IsEmpty). Is there any plan to upgrade
>>> the version of
>>>> > NUnit that is
>>>> > > used with the Mono build/test?
>>>> >
>>>> >
>>>> > The NUnit that ships with Mono should be considered
>>>> Mono's own
>>>> > copy of
>>>> > NUnit and not a public version of it.
>>>> >
>>>> > We should probably make packages of the
>>> latest version of
>>>> > NUnit,
>>>> > encourage the NUnit developer to maintain
>>> those and encourage
>>>> > developers
>>>> > to use the public NUnit as opposed to the
>>> private copy that
>>>> > Mono ships.
>>>> >
>>>> >
>>>>
>>>>
>>>>
>>>>
>>> ----------------------------------------------------------------------
>>>> --
>>>>
>>>> _______________________________________________
>>>> Mono-list maillist - Mono-list@lists.ximian.com
>>>> http://lists.ximian.com/mailman/listinfo/mono-list
>>> _______________________________________________
>>> Mono-list maillist - Mono-list@lists.ximian.com
>>> http://lists.ximian.com/mailman/listinfo/mono-list
>>>
>>
>>
>> _______________________________________________
>> Mono-list maillist - Mono-list@lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-list
>>
>
> _______________________________________________
> Mono-list maillist - Mono-list@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-list
>
["nunit-upgrade-20-to-24.patch" (text/x-patch)]
Index: build/library.make
===================================================================
--- build/library.make (revision 119705)
+++ build/library.make (working copy)
@@ -195,7 +195,7 @@
run-test-local: run-test-lib
run-test-ondotnet-local: run-test-ondotnet-lib
-TEST_HARNESS_EXCLUDES = /exclude:NotWorking,ValueAdd,CAS,InetAccess
+TEST_HARNESS_EXCLUDES = -exclude=NotWorking,ValueAdd,CAS,InetAccess
TEST_HARNESS_EXCLUDES_ONDOTNET = /exclude:NotDotNet,CAS
ifdef TEST_HARNESS_VERBOSE
@@ -204,8 +204,8 @@
TEST_HARNESS_POSTPROC = :
TEST_HARNESS_POSTPROC_ONDOTNET = :
else
-TEST_HARNESS_OUTPUT = /output:TestResult-$(PROFILE).log
-TEST_HARNESS_OUTPUT_ONDOTNET = /output:TestResult-ondotnet-$(PROFILE).log
+TEST_HARNESS_OUTPUT = -output=TestResult-$(PROFILE).log
+TEST_HARNESS_OUTPUT_ONDOTNET = -output=TestResult-ondotnet-$(PROFILE).log
TEST_HARNESS_POSTPROC = (echo ''; cat TestResult-$(PROFILE).log) | sed '1,/^Tests \
run: /d' TEST_HARNESS_POSTPROC_ONDOTNET = (echo ''; cat \
TestResult-ondotnet-$(PROFILE).log) | sed '1,/^Tests run: /d' endif
@@ -217,12 +217,12 @@
## FIXME: i18n problem in the 'sed' command below
run-test-lib: test-local
ok=:; \
- MONO_REGISTRY_PATH="$(HOME)/.mono/registry" $(TEST_RUNTIME) $(RUNTIME_FLAGS) \
$(TEST_HARNESS) $(TEST_HARNESS_FLAGS) $(LOCAL_TEST_HARNESS_FLAGS) \
$(TEST_HARNESS_EXCLUDES) $(TEST_HARNESS_OUTPUT) /xml:TestResult-$(PROFILE).xml \
$(test_assemblies) $(FIXTURE_ARG) || ok=false; \ \
+ MONO_REGISTRY_PATH="$(HOME)/.mono/registry" $(TEST_RUNTIME) $(RUNTIME_FLAGS) \
$(TEST_HARNESS) $(test_assemblies) -noshadow $(TEST_HARNESS_FLAGS) \
$(LOCAL_TEST_HARNESS_FLAGS) $(TEST_HARNESS_EXCLUDES) $(TEST_HARNESS_OUTPUT) \
-xml=TestResult-$(PROFILE).xml $(FIXTURE_ARG) || ok=false; \ \
$(TEST_HARNESS_POSTPROC) ; $$ok
run-test-ondotnet-lib: test-local
ok=:; \
- $(TEST_HARNESS) $(TEST_HARNESS_FLAGS) $(LOCAL_TEST_HARNESS_ONDOTNET_FLAGS) \
$(TEST_HARNESS_EXCLUDES_ONDOTNET) $(TEST_HARNESS_OUTPUT_ONDOTNET) \
/xml:TestResult-ondotnet-$(PROFILE).xml $(test_assemblies) || ok=false; \ \
+ $(TEST_HARNESS) $(test_assemblies) -noshadow $(TEST_HARNESS_FLAGS) \
$(LOCAL_TEST_HARNESS_ONDOTNET_FLAGS) $(TEST_HARNESS_EXCLUDES_ONDOTNET) \
$(TEST_HARNESS_OUTPUT_ONDOTNET) -xml=TestResult-ondotnet-$(PROFILE).xml || ok=false; \
\ $(TEST_HARNESS_POSTPROC_ONDOTNET) ; $$ok
endif
Index: class/System/Makefile
===================================================================
--- class/System/Makefile (revision 119705)
+++ class/System/Makefile (working copy)
@@ -138,8 +138,8 @@
ifeq (net_2_0, $(PROFILE))
pkits_files := $(wildcard \
Test/System.Security.Cryptography.X509Certificates/pkits/hint) ifndef pkits_files
-TEST_HARNESS_EXCLUDES = /exclude:NotWorking,ValueAdd,CAS,InetAccess,PKITS
-TEST_HARNESS_EXCLUDES_ONDOTNET = /exclude:NotDotNet,CAS,PKITS
+TEST_HARNESS_EXCLUDES = -exclude:NotWorking,ValueAdd,CAS,InetAccess,PKITS
+TEST_HARNESS_EXCLUDES_ONDOTNET = -exclude:NotDotNet,CAS,PKITS
endif
endif
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic