[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mono-devel-list
Subject:    Re: [Mono-dev] [Patch] Fix for leak in List`1,
From:       "Zoltan Varga" <vargaz () gmail ! com>
Date:       2008-05-29 11:53:34
Message-ID: 295e750a0805290453tcc8e10le1526435e4dce0ad () mail ! gmail ! com
[Download RAW message or body]

Hi,

This looks ok to check in. Although I would add a if (j -i > 0) before
the Array.Clear ()
call RemoveAll ().

               Zoltan

2008/5/29 Juraj Skripsky <js@hotfeet.ch>:
> Hello,
>
> Attached you'll find two patches:
>
>      * a fix for a memory leak in List`1
>      * a tiny optimization for ArrayList (inspired by code in List`1)
>
> ChangeLog entries are included and all corlib unit tests pass.
> Please review.
>
> - Juraj
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic