[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mono-devel-list
Subject:    Re: [Mono-dev] System.Configuration patches
From:       Chris Toshok <toshok () ximian ! com>
Date:       2007-01-31 23:16:26
Message-ID: 1170285386.2244.7.camel () tinytoph ! toshok ! org
[Download RAW message or body]

The System.Configuration maintainers might be better equipped to answer
this, but I'll give it a go:


both patches need indentation work.

the ConfigSource one looks fine to me.

the ConfigurationElement.cs patch looks wrong.  A test case for this
would be useful (to verify that the TypeConverter property is correct),
and should be easy to create.

Also, we shouldn't be using System.Reflection at all for that method.
We should be using System.ComponentModel, with
TypeDescriptor/PropertyDescriptor (and
their respective TypeConverter method/property).  That'll simplify the
code a bunch.

Chris

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
[prev in list] [next in list] [prev in thread] [next in thread]