[prev in list] [next in list] [prev in thread] [next in thread] 

List:       monetdb-checkins
Subject:    MonetDB: Jun2016 - Improved getBestRowIdentifier() to return inf...
From:       Martin van Dinther <commits+martin.van.dinther=monetdbsolutions.com () monetdb ! org>
Date:       2016-06-30 17:56:54
Message-ID: hg.37c64af3d847.1467309414.6315528441665844383 () monetdb2 ! cwi-incubator ! nl
[Download RAW message or body]

Changeset: 37c64af3d847 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=37c64af3d847
Modified Files:
	java/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
Branch: Jun2016
Log Message:

Improved getBestRowIdentifier() to return information also for other
two allowed scope types.i
For instance SQuirreL calls this method with scope bestRowTransaction
and hence never retrieved/showed any data. Now it does.


diffs (12 lines):

diff --git a/java/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java \
                b/java/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
--- a/java/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
+++ b/java/src/main/java/nl/cwi/monetdb/jdbc/MonetDatabaseMetaData.java
@@ -2476,7 +2476,7 @@ public class MonetDatabaseMetaData exten
 		if (table != null) {
 			query.append(" AND \"tables\".\"name\" ").append(composeMatchPart(table));
 		}
-		if (scope != DatabaseMetaData.bestRowSession) {
+		if (scope != DatabaseMetaData.bestRowSession && scope != \
DatabaseMetaData.bestRowTransaction && scope != DatabaseMetaData.bestRowTemporary) {  \
query.append(" AND 1 = 0");  }
 		if (!nullable) {
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list


[prev in list] [next in list] [prev in thread] [next in thread]