[prev in list] [next in list] [prev in thread] [next in thread] 

List:       moblin-commits
Subject:    [Moblin-Commits] moblin-media: Changes to 'master'
From:       john () moblin ! org (John Villalovos)
Date:       2008-02-29 15:15:19
Message-ID: 20080229231517.2A0211E74002 () moblin ! org
[Download RAW message or body]

 debian/changelog    |    6 ++++--
 src/image_finger.py |   14 ++++++++------
 2 files changed, 12 insertions(+), 8 deletions(-)

New commits:
commit accf9116e9750aed5ebebf339978688993eea957
Author: John L. Villalovos <john.l.villalovos@intel.com>
Date:   Fri Feb 29 15:15:12 2008 -0800

    Fix for bug: https://bugs.launchpad.net/moblin-multimedia/+bug/194296 Image \
rotation causes loss in image quality.  Fix provided by Prajwal


Diff in this email is a maximum of 400 lines.
diff --git a/debian/changelog b/debian/changelog
index f656728..cb15f5d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,7 +4,7 @@ moblin-media (0.38) gaston; urgency=low
   * Landing a fix for https://bugs.launchpad.net/moblin-multimedia/+bug/192255
     where an extra thumbnail icon will be added to an iconview after rotating
   * Landing fix for https://bugs.launchpad.net/moblin-multimedia/+bug/192846
-    where USB host import would break on a system configured with the 
+    where USB host import would break on a system configured with the
     media files located on a vfat partition
 
   [ John L. Villalovos ]
@@ -13,8 +13,10 @@ moblin-media (0.38) gaston; urgency=low
     umask=000 in my opinion
   * Landing a fix for https://bugs.launchpad.net/moblin-multimedia/+bug/192255
     where an extra thumbnail icon will be added to an iconview after rotating
+  * Fix for bug: https://bugs.launchpad.net/moblin-multimedia/+bug/194296
+    Image rotation causes loss in image quality.  Fix provided by Prajwal
 
- -- Rusty Lynch <rusty.lynch@intel.com>  Thu, 21 Feb 2008 18:29:21 -0800
+ -- John L. Villalovos <john.l.villalovos@intel.com>  Fri, 29 Feb 2008 15:13:14 \
-0800  
 moblin-media (0.37) gaston; urgency=low
 
diff --git a/src/image_finger.py b/src/image_finger.py
index c3b04d6..76b7fd2 100755
--- a/src/image_finger.py
+++ b/src/image_finger.py
@@ -141,7 +141,14 @@ class image_finger(gtk.EventBox):
             self.image_pb = \
self.image_pb.rotate_simple(gtk.gdk.PIXBUF_ROTATE_COUNTERCLOCKWISE)  if rotate == \
                'R':
             self.image_pb = \
                self.image_pb.rotate_simple(gtk.gdk.PIXBUF_ROTATE_CLOCKWISE)
-
+        # If we rotated the image, need to save it back to disk, before we do
+        # the image scaling for display, otherwise we will lose the image
+        # dimensions
+        if rotate in ['R','r']:
+            extra_param = {}
+            if self.image_format == "jpeg":
+                extra_param = {"quality":"100"}
+            self.image_pb.save(self.image_file, self.image_format, extra_param)
         width = self.image_pb.get_width()
         height = self.image_pb.get_height()
         IncreaseBy = self.resize_increaseby
@@ -160,11 +167,6 @@ class image_finger(gtk.EventBox):
                     image_pb = self.image_pb.scale_simple( size.width , \
height*size.width/width, gtk.gdk.INTERP_BILINEAR )  else:
                     image_pb = self.image_pb.scale_simple( width*size.height/height, \
                size.height, gtk.gdk.INTERP_BILINEAR )
-
-        # If we rotated the image, need to save it back to disk
-        if rotate in ['R','r']:
-            image_pb.save(self.image_file, self.image_format)
-
         self.image.set_from_pixbuf(image_pb)
         self.image.show()
         gc.collect()


[prev in list] [next in list] [prev in thread] [next in thread]