[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mina-dev
Subject:    [jira] [Commented] (DIRMINA-1088) OrderedThreadPool implementation should be compatible with Java 10
From:       "Emmanuel Lecharny (JIRA)" <jira () apache ! org>
Date:       2018-07-30 18:52:00
Message-ID: JIRA.13169176.1530282797000.120385.1532976720499 () Atlassian ! JIRA
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/DIRMINA-1088?page=com.atlassian.jira.plugi \
n.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562352#comment-16562352 ] \


Emmanuel Lecharny commented on DIRMINA-1088:
--------------------------------------------

Patch applied to 2.1.0 too.

> OrderedThreadPool implementation should be compatible with Java 10
> ------------------------------------------------------------------
> 
> Key: DIRMINA-1088
> URL: https://issues.apache.org/jira/browse/DIRMINA-1088
> Project: MINA
> Issue Type: Bug
> Components: Core
> Reporter: Guus der Kinderen
> Priority: Major
> Attachments: orderedthreadpool.patch
> 
> 
> {{org.apache.mina.filter.executor.OrderedThreadPoolExecutor}} inherits from \
> {{java.util.concurrent.ThreadPoolExecutor}} OrderedThreadPoolExecutor, in its \
> constructor, calls these two methods from its parent to determine pool sizing: \
> {code:java} super.setCorePoolSize(corePoolSize);
> super.setMaximumPoolSize(maximumPoolSize);{code}
> This works fine up until Java 8. In Java 10 (possibly 9 - I did not check), an \
> additional input validation was added to {{ThreadPoolExecutor#setCorePoolSize}}: \
> {{maximumPoolSize < corePoolSize}} ThreadPoolExecutor Java 8:
> {code:java}
> public void setCorePoolSize(int corePoolSize) {
> if (corePoolSize < 0)
> throw new IllegalArgumentException();
> public void setMaximumPoolSize(int maximumPoolSize) {
> if (maximumPoolSize <= 0 || maximumPoolSize < corePoolSize)
> throw new IllegalArgumentException();
> {code}
> ThreadPoolExecutor Java 10:
> {code:java}
> public void setCorePoolSize(int corePoolSize) {
> if (corePoolSize < 0 || maximumPoolSize < corePoolSize)
> throw new IllegalArgumentException();
> public void setMaximumPoolSize(int maximumPoolSize) {
> if (maximumPoolSize <= 0 || maximumPoolSize < corePoolSize)
> throw new IllegalArgumentException();
> {code}
> As a result, the first line of this part of the constructor of \
> OrderedThreadPoolExecutor now throws an IllegalArgumentException. {code:java}
> super.setCorePoolSize(corePoolSize);
> super.setMaximumPoolSize(maximumPoolSize);{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[prev in list] [next in list] [prev in thread] [next in thread]