[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mina-dev
Subject:    Re: [VOTE] MINA 2.0.4
From:       Emmanuel Lecharny <elecharny () gmail ! com>
Date:       2011-05-31 23:49:00
Message-ID: 4DE57E6C.7030201 () gmail ! com
[Download RAW message or body]

On 6/1/11 1:39 AM, sebb wrote:
> On 1 June 2011 00:24, Emmanuel Lecharny<elecharny@gmail.com>  wrote:
>> On 5/31/11 7:31 PM, sebb wrote:
>>> On 30 May 2011 09:21, Julien Vermillard<jvermillard@gmail.com>    wrote:
>>>> This is a bug fix release.
>>>>
>>>> Fixed issues :
>>>>
>>>> https://issues.apache.org/jira/browse/DIRMINA-832
>>>> NullPointerException logged by ExceptionMonitor while invoking a
>>>> NioSocketConnector.connect() that fails
>>>>
>>>> https://issues.apache.org/jira/browse/DIRMINA-830
>>>> DIRMINA-830 Unconditional wait() in Read- and WriteWorker of
>>>> SerialSessionImpl
>>>>
>>>> A temporary tag has been created (it can be removed if the vote is not
>>>> approved): http://svn.apache.org/viewvc/mina/tags/2.0.4/
>>> Maybe next time consider creating an RC1 tag.
>> It's not necessary, as we are just fixing bugs in such versions.
> Does not matter if you are only correcting a typo; it's important that
> what is being voted on is uniquely identified.
>
> IMO, tags should be immutable. Much simpler in the long run.
They are. if we can't vote a tag, then it's deleted, until we can get a 
positive vote.

But I see where you are heading to.

This can be discussed.

>>> If the vote does not succeed, create a new tag (RC2) and repeat.
>>> If the vote succeeds, rename the RCn tag as the release tag.
>>> That way, the release tag is immutable.
>>> Failed RCn tags can be removed after the voting has finished.
>>>
>>> If release tags can be deleted and re-created, how can one know which
>>> version of the tag was reviewed?
>> because we provide the svn revision number. Hmmm, has it been provided ? if
>> not, that's a mistake.
> AFAICT it has not been provided.

bad...

Frankly, I do think now that it may be better to stop the vote and fix 
some of the issues we have (the latest you created, plus a new one).

We can then start a discussion about the best way to vote a dedicated 
version, before moving it to an immutable tag.

Let's see what Julien will say...

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

[prev in list] [next in list] [prev in thread] [next in thread]