[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mina-commits
Subject:    [mina] branch 2.2.X updated: write direct buffer only once
From:       johnnyv () apache ! org
Date:       2023-01-07 22:01:14
Message-ID: 167312887424.3792388.6731572850576066292 () gitbox2-he-fi ! apache ! org
[Download RAW message or body]

This is an automated email from the ASF dual-hosted git repository.

johnnyv pushed a commit to branch 2.2.X
in repository https://gitbox.apache.org/repos/asf/mina.git


The following commit(s) were added to refs/heads/2.2.X by this push:
     new 4ba415161 write direct buffer only once
     new b8b6d457a Merge pull request #37 from subes/patch-1
4ba415161 is described below

commit 4ba41516164c377ada8d28569a444ad201f58a56
Author: Edwin Stang <gsubes@gmail.com>
AuthorDate: Sat Jan 7 12:24:28 2023 +0100

    write direct buffer only once
    
    fixes an endless loop when writing a direct buffer in APR
---
 .../java/org/apache/mina/transport/socket/apr/AprIoProcessor.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mina-transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java \
b/mina-transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java
 index 3d0e4abbe..377ddcfee 100644
--- a/mina-transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java
                
+++ b/mina-transport-apr/src/main/java/org/apache/mina/transport/socket/apr/AprIoProcessor.java
 @@ -434,9 +434,9 @@ public final class AprIoProcessor extends \
                AbstractPollingIoProcessor<AprSession>
             writtenBytes = Socket.sendb(session.getDescriptor(), buf.buf(), \
buf.position(), length);  } else {
             writtenBytes = Socket.send(session.getDescriptor(), buf.array(), \
                buf.position(), length);
-            if (writtenBytes > 0) {
-                buf.skip(writtenBytes);
-            }
+        }
+        if (writtenBytes > 0) {
+            buf.skip(writtenBytes);
         }
 
         if (writtenBytes < 0) {


[prev in list] [next in list] [prev in thread] [next in thread]