[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mina-commits
Subject:    svn commit: r709044 -
From:       elecharny () apache ! org
Date:       2008-10-29 23:42:19
Message-ID: 20081029234219.D3F7123888F4 () eris ! apache ! org
[Download RAW message or body]

Author: elecharny
Date: Wed Oct 29 16:42:19 2008
New Revision: 709044

URL: http://svn.apache.org/viewvc?rev=709044&view=rev
Log:
Removed the 'break' in the decoding loop. When the decoder is stateful, this 'break' \
just makes some part of the buffer to be lost.

This will fix DIRMINA-633

Modified:
    mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java


Modified: mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
                
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java?rev=709044&r1=709043&r2=709044&view=diff
 ==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java \
                (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java \
Wed Oct 29 16:42:19 2008 @@ -260,13 +260,9 @@
                     // Call the decoder with the read bytes
                     decoder.decode(session, in, decoderOut);
                 }
+                
                 // Finish decoding if no exception was thrown.
                 decoderOut.flush();
-                
-                // TODO :
-                // here, we shouldn't break,
-                // we should loop to decode the next portion of the buffer.
-                break;
             } catch (Throwable t) {
                 ProtocolDecoderException pde;
                 if (t instanceof ProtocolDecoderException) {


[prev in list] [next in list] [prev in thread] [next in thread]