[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesos-issues
Subject:    [jira] [Assigned] (MESOS-9337) Hook manager implementation is missing mutex acquisition in several p
From:       "Benjamin Mahler (Jira)" <jira () apache ! org>
Date:       2020-03-30 16:56:00
Message-ID: JIRA.13192956.1539980474000.27084.1585587360262 () Atlassian ! JIRA
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/MESOS-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Benjamin Mahler reassigned MESOS-9337:
--------------------------------------

    Assignee: Dong Zhu

> Hook manager implementation is missing mutex acquisition in several places.
> ---------------------------------------------------------------------------
> 
> Key: MESOS-9337
> URL: https://issues.apache.org/jira/browse/MESOS-9337
> Project: Mesos
> Issue Type: Bug
> Components: modules
> Reporter: Benjamin Mahler
> Assignee: Dong Zhu
> Priority: Major
> 
> The hook manager uses a mutex to protect availableHooks from writing during read \
> (probably this should be a read/write mutex). However, this mutex is not acquired \
> in many of the reads. For example: (mutex acquired)
> https://github.com/apache/mesos/blob/1.7.0/src/hook/manager.cpp#L108-L138
> (mutex not acquired!)
> https://github.com/apache/mesos/blob/1.7.0/src/hook/manager.cpp#L141-L150
> Also, the mutex and map are non-POD statics, which are banned:
> https://github.com/apache/mesos/blob/1.9.0/src/hook/manager.cpp#L50-L51



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[prev in list] [next in list] [prev in thread] [next in thread]