[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesos-dev
Subject:    Re: Review Request 19499: Ported slave statistics over to new metrics library.
From:       "Dominic Hamon" <dhamon () twopensource ! com>
Date:       2014-04-30 17:39:23
Message-ID: 20140430173923.4204.38575 () reviews ! apache ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
-----------------------------------------------------------

(Updated April 30, 2014, 10:39 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

rebased and moved metrics into struct.


Bugs: MESOS-1133
    https://issues.apache.org/jira/browse/MESOS-1133


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5 
  src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4 

Diff: https://reviews.apache.org/r/19499/diff/


Testing
-------

make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.


Thanks,

Dominic Hamon



[prev in list] [next in list] [prev in thread] [next in thread]