[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesos-dev
Subject:    Re: Review Request 13880: launcher: Fix os::chdir return value checking.
From:       "Ben Mahler" <benjamin.mahler () gmail ! com>
Date:       2013-08-30 0:51:28
Message-ID: 20130830005128.16847.31139 () reviews ! apache ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13880/#review25777
-----------------------------------------------------------


Please mark as submitted!

- Ben Mahler


On Aug. 28, 2013, 4:24 a.m., Vinson Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13880/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 4:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric Biederman, \
> David Mackey, and Vinod Kone. 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Author: Vinson Lee <vlee@twitter.com>
> 
> launcher: Fix os::chdir return value checking.
> 
> os::chdir returns a boolean value and not an integer value.
> 
> Fixes "Operands don't affect result" defects reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee@twitter.com>
> 
> 
> Diffs
> -----
> 
> src/launcher/launcher.cpp 7bf127a 
> 
> Diff: https://reviews.apache.org/r/13880/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Vinson Lee
> 
> 



[prev in list] [next in list] [prev in thread] [next in thread]