[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesos-dev
Subject:    [jira] [Commented] (MESOS-175) Unused portions of offers are not immediately offered to another fram
From:       "jiraposter () reviews ! apache ! org (Commented) (JIRA)" <jira () apache ! org>
Date:       2012-03-30 6:44:51
Message-ID: 684257398.36799.1333089891338.JavaMail.tomcat () hel ! zones ! apache ! org
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/MESOS-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242107#comment-13242107 \
] 

jiraposter@reviews.apache.org commented on MESOS-175:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4570/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Summary
-------

Make sure removeOffer() is called before resourcesUnused()/resourcesRecovered() is \
called on the allocator.

This ensures that the allocator will see a correct value from \
master::Slave::resourcesFree().


This addresses bug MESOS-175.
    https://issues.apache.org/jira/browse/MESOS-175


Diffs
-----

  src/master/master.hpp 8a34d7e 
  src/master/master.cpp 4dc9ee0 
  src/tests/resource_offers_tests.cpp c1f1760 

Diff: https://reviews.apache.org/r/4570/diff


Testing
-------

make check (two new tests included)


Thanks,

Charles


                
> Unused portions of offers are not immediately offered to another framework
> --------------------------------------------------------------------------
> 
> Key: MESOS-175
> URL: https://issues.apache.org/jira/browse/MESOS-175
> Project: Mesos
> Issue Type: Bug
> Reporter: Charles Reiss
> Priority: Minor
> 
> When a framework returns an offer but does not use the entire offer, the master \
> calls allocator to make new allocations for that offer. Unfortunately, it currently \
> does so before removing the offer, so the current allocator will not consider those \
> resources free, and so the allocator will think it those resources are not free. In \
> practice, the resources will be offered on the next timer tick, framework \
> registration, or other event causing the slave to be reconsidered for offers, so \
> this is a relatively low impact issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: \
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more \
information on JIRA, see: http://www.atlassian.com/software/jira

        


[prev in list] [next in list] [prev in thread] [next in thread]