[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesos-commits
Subject:    [mesos] branch 1.9.x updated: Fixed wclayer download in Windows build with CMake 3.17+
From:       asekretenko () apache ! org
Date:       2020-06-29 14:19:52
Message-ID: 159344039287.6424.12445464586661632842 () gitbox ! apache ! org
[Download RAW message or body]

This is an automated email from the ASF dual-hosted git repository.

asekretenko pushed a commit to branch 1.9.x
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/1.9.x by this push:
     new a52b143  Fixed wclayer download in Windows build with CMake 3.17+
a52b143 is described below

commit a52b14310050f5a26b0f044deb11383e92979a34
Author: Eduard Staniloiu <edi33416@gmail.com>
AuthorDate: Tue Jun 23 16:02:04 2020 +0300

    Fixed wclayer download in Windows build with CMake 3.17+
    
    This fixes incorrect setting `DOWNLOAD_NO_EXTRACT FALSE` in the
    `wclayer` ExternalProject target, which breaks Windows build starting
    from CMake 3.17+
    
    The bug has apparently been triggered by the fix in the ExternalProject
    module that makes `DOWNLOAD_NO_EXTRACT OFF`/`DOWNLOAD_NO_EXTRACT FALSE`
    work correctly:
    https://github.com/Kitware/CMake/commit/2c4bb705e842db66904df5014a5755b57ac51b72
    
    This closes #366
---
 3rdparty/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
index 23ef7c1..2f18393 100644
--- a/3rdparty/CMakeLists.txt
+++ b/3rdparty/CMakeLists.txt
@@ -893,7 +893,7 @@ if (WIN32)
     CONFIGURE_COMMAND   ${CMAKE_NOOP}
     BUILD_COMMAND       ${CMAKE_NOOP}
     INSTALL_COMMAND     ${WCLAYER_INSTALL_CMD}
-    DOWNLOAD_NO_EXTRACT FALSE
+    DOWNLOAD_NO_EXTRACT TRUE
     URL                 ${WCLAYER_URL})
 endif ()
 

[prev in list] [next in list] [prev in thread] [next in thread]