[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesos-commits
Subject:    git commit: Fixed broken build on GCC 4.8 due to -Wall.
From:       brenden () apache ! org
Date:       2013-09-16 21:11:12
Message-ID: 2bbd29ee00f04a9ab45b9a4700fb359e () git ! apache ! org
[Download RAW message or body]

Updated Branches:
  refs/heads/master f2571b55f -> 37e946683


Fixed broken build on GCC 4.8 due to -Wall.

With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which
is implied by '-Wall'.

Review: https://reviews.apache.org/r/11974/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/37e94668
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/37e94668
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/37e94668

Branch: refs/heads/master
Commit: 37e946683f1bb6ae53d80dc55b7736307bffee9c
Parents: f2571b5
Author: Brenden Matthews <brenden.matthews@airbnb.com>
Authored: Mon Jun 17 12:58:16 2013 -0700
Committer: Brenden Matthews <brenden.matthews@airbnb.com>
Committed: Mon Sep 16 14:10:51 2013 -0700

----------------------------------------------------------------------
 configure.ac | 8 ++++++++
 1 file changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/37e94668/configure.ac
----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index dec1897..73baf03 100644
--- a/configure.ac
+++ b/configure.ac
@@ -51,6 +51,14 @@ LT_OUTPUT
 AS_IF([test "x${ac_cv_env_CFLAGS_set}" = "x"], [CFLAGS="-g"])
 AS_IF([test "x${ac_cv_env_CXXFLAGS_set}" = "x"], [CXXFLAGS="-g"])
 
+# Boost 1.53.0 won't compile with GCC 4.8 without -Wno-unused-local-typedefs,
+# and automake doesn't recognize the flag.
+# TODO(brenden): remove this when Boost has a resolution.
+if test "x$GCC" = "xyes"; then
+  CFLAGS="${CFLAGS} -Wno-unused-local-typedefs"
+  CXXFLAGS="${CXXFLAGS} -Wno-unused-local-typedefs"
+fi
+
 # Save the configure arguments so we can pass them to any third-party
 # libraries that we might run configure on (see
 # 3rdparty/Makefile.am). One downside of our strategy for shipping and


[prev in list] [next in list] [prev in thread] [next in thread]