[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH] util/atomic: Add p_atomic_add_return for the unlocked path
From:       Jason Ekstrand <jason () jlekstrand ! net>
Date:       2019-12-05 17:55:56
Message-ID: CAOFGe95fGKR3=DvusB+X8iD=OQXKA_G3=3KCZXZHV+ojbDNPLA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Pushed.  Thanks for catching this!

On Thu, Dec 5, 2019 at 11:52 AM Ilia Mirkin <imirkin@alum.mit.edu> wrote:

> Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
>
> On Thu, Dec 5, 2019 at 12:51 PM Jason Ekstrand <jason@jlekstrand.net>
> wrote:
> >
> > Fixes: 385d13f26d2 "util/atomic: Add a _return variant of p_atomic_add"
> > ---
> >  src/util/u_atomic.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h
> > index 45e8e2e0188..9cbc6dd1eaa 100644
> > --- a/src/util/u_atomic.h
> > +++ b/src/util/u_atomic.h
> > @@ -92,7 +92,7 @@
> >  #define p_atomic_add(_v, _i) ((void) p_atomic_add_return((_v), (_i))
> >  #define p_atomic_inc_return(_v) (++(*(_v)))
> >  #define p_atomic_dec_return(_v) (--(*(_v)))
> > -#define p_atomic_add(_v, _i) (*(_v) = *(_v) + (_i))
> > +#define p_atomic_add_return(_v, _i) (*(_v) = *(_v) + (_i))
> >  #define p_atomic_cmpxchg(_v, _old, _new) (*(_v) == (_old) ? (*(_v) =
> (_new), (_old)) : *(_v))
> >
> >  #endif
> > --
> > 2.23.0
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>

[Attachment #5 (text/html)]

<div dir="ltr">Pushed.   Thanks for catching this!<br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Dec 5, 2019 at 11:52 AM \
Ilia Mirkin &lt;<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Reviewed-by: Ilia \
Mirkin &lt;<a href="mailto:imirkin@alum.mit.edu" \
target="_blank">imirkin@alum.mit.edu</a>&gt;<br> <br>
On Thu, Dec 5, 2019 at 12:51 PM Jason Ekstrand &lt;<a \
href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>&gt; \
wrote:<br> &gt;<br>
&gt; Fixes: 385d13f26d2 &quot;util/atomic: Add a _return variant of \
p_atomic_add&quot;<br> &gt; ---<br>
&gt;   src/util/u_atomic.h | 2 +-<br>
&gt;   1 file changed, 1 insertion(+), 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/src/util/u_atomic.h b/src/util/u_atomic.h<br>
&gt; index 45e8e2e0188..9cbc6dd1eaa 100644<br>
&gt; --- a/src/util/u_atomic.h<br>
&gt; +++ b/src/util/u_atomic.h<br>
&gt; @@ -92,7 +92,7 @@<br>
&gt;   #define p_atomic_add(_v, _i) ((void) p_atomic_add_return((_v), (_i))<br>
&gt;   #define p_atomic_inc_return(_v) (++(*(_v)))<br>
&gt;   #define p_atomic_dec_return(_v) (--(*(_v)))<br>
&gt; -#define p_atomic_add(_v, _i) (*(_v) = *(_v) + (_i))<br>
&gt; +#define p_atomic_add_return(_v, _i) (*(_v) = *(_v) + (_i))<br>
&gt;   #define p_atomic_cmpxchg(_v, _old, _new) (*(_v) == (_old) ? (*(_v) = (_new), \
(_old)) : *(_v))<br> &gt;<br>
&gt;   #endif<br>
&gt; --<br>
&gt; 2.23.0<br>
&gt;<br>
&gt; _______________________________________________<br>
&gt; mesa-dev mailing list<br>
&gt; <a href="mailto:mesa-dev@lists.freedesktop.org" \
target="_blank">mesa-dev@lists.freedesktop.org</a><br> &gt; <a \
href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" \
target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br> \
</blockquote></div>


[Attachment #6 (text/plain)]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[prev in list] [next in list] [prev in thread] [next in thread]