[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] boolean usage in gallium
From:       Marek Olšák <maraeo () gmail ! com>
Date:       2019-06-30 5:00:52
Message-ID: CAAxE2A4BBBUWdBQHie0XNywAE3Kecm70DS-PFYB0WcVD80M3qQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


boolean predates c99 support in MSVC. I think there is no reason for
boolean in gallium now.

Marek

On Sat., Jun. 29, 2019, 00:09 Ilia Mirkin, <imirkin@alum.mit.edu> wrote:

> Ken pointed out on IRC today that there was still a lot of "boolean"
> (vs bool/_Bool) usage in gallium. In fact, many interfaces are
> specified with boolean.
>
> I had it in my mind that I had at some point removed most boolean
> usage, but that is just not the case - first of all, the interfaces
> remain with it, and I could find no evidence of such a commit. I must
> have imagined it.
>
> Is there any reason to keep boolean around? I know conversions must be
> done carefully (since incorrect-but-working usage would not currently
> be caught by the compiler), but are there any practical reasons to
> avoid C99 _Bool in gallium code?
>
> If not, I may begin converting things over.
>
> Cheers,
>
>   -ilia
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Attachment #5 (text/html)]

<div dir="auto">boolean predates c99 support in MSVC. I think there is no reason for \
boolean in gallium now.<div dir="auto"><br></div><div \
dir="auto">Marek</div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat., Jun. 29, 2019, 00:09 Ilia Mirkin, &lt;<a \
href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Ken pointed out on IRC today that \
there was still a lot of &quot;boolean&quot;<br> (vs bool/_Bool) usage in gallium. In \
fact, many interfaces are<br> specified with boolean.<br>
<br>
I had it in my mind that I had at some point removed most boolean<br>
usage, but that is just not the case - first of all, the interfaces<br>
remain with it, and I could find no evidence of such a commit. I must<br>
have imagined it.<br>
<br>
Is there any reason to keep boolean around? I know conversions must be<br>
done carefully (since incorrect-but-working usage would not currently<br>
be caught by the compiler), but are there any practical reasons to<br>
avoid C99 _Bool in gallium code?<br>
<br>
If not, I may begin converting things over.<br>
<br>
Cheers,<br>
<br>
   -ilia<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank" \
rel="noreferrer">mesa-dev@lists.freedesktop.org</a><br> <a \
href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer \
noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote></div>



[Attachment #6 (text/plain)]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[prev in list] [next in list] [prev in thread] [next in thread]