[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.
From:       Jason Ekstrand <jason () jlekstrand ! net>
Date:       2018-05-31 21:59:58
Message-ID: CAOFGe94zRbmTeTRBU7ToN=qbGZV0kkJ_wrG+34S50q6sJLjUdw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


If you could deal with Daniel's feedback and v3 just this patch sooner
rather than later, that would be good.  I'd like to merge it before we
switch to gitlab so we can start using gitlab CI artifacts for the website
right away.  That way, it'll be ready for when the rest of the series lands.

On Thu, May 31, 2018 at 12:52 AM, Daniel Stone <daniel@fooishbar.org> wrote:

> Hi Laura,
>
> On 30 May 2018 at 23:53, Laura Ekstrand <laura@jlekstrand.net> wrote:
> > @@ -0,0 +1,9 @@
> > +pages:
> > +   stage: deploy
> > +   script:
> > +   - mkdir .public
> > +   - cp -r docs/* .public
> > +   - mv .public public
>
> You should be able to just write into the 'public' folder directly.
>
> It seems like creating a new directory and then moving it is an
> attempt to be atomic, which is absolutely the right thing to do! But
> the Pages deploy is separate: the build starts from a completely clean
> slate, and does not overwrite the live website being served by Pages.
> It's only once the build has finished and the artifacts captured that
> they're later moved in-place to serve Pages.
>
> Cheers,
> Daniel
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>

[Attachment #5 (text/html)]

<div dir="ltr">If you could deal with Daniel&#39;s feedback and v3 just this patch \
sooner rather than later, that would be good.   I&#39;d like to merge it before we \
switch to gitlab so we can start using gitlab CI artifacts for the website right \
away.   That way, it&#39;ll be ready for when the rest of the series \
lands.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 31, \
2018 at 12:52 AM, Daniel Stone <span dir="ltr">&lt;<a \
href="mailto:daniel@fooishbar.org" \
target="_blank">daniel@fooishbar.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Laura,<br> <span class=""><br>
On 30 May 2018 at 23:53, Laura Ekstrand &lt;<a \
href="mailto:laura@jlekstrand.net">laura@jlekstrand.net</a>&gt; wrote:<br> &gt; @@ \
-0,0 +1,9 @@<br> &gt; +pages:<br>
&gt; +     stage: deploy<br>
&gt; +     script:<br>
&gt; +     - mkdir .public<br>
&gt; +     - cp -r docs/* .public<br>
&gt; +     - mv .public public<br>
<br>
</span>You should be able to just write into the &#39;public&#39; folder \
directly.<br> <br>
It seems like creating a new directory and then moving it is an<br>
attempt to be atomic, which is absolutely the right thing to do! But<br>
the Pages deploy is separate: the build starts from a completely clean<br>
slate, and does not overwrite the live website being served by Pages.<br>
It&#39;s only once the build has finished and the artifacts captured that<br>
they&#39;re later moved in-place to serve Pages.<br>
<br>
Cheers,<br>
Daniel<br>
<div class="HOEnZb"><div \
class="h5">______________________________<wbr>_________________<br> mesa-dev mailing \
list<br> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
 <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" \
target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> \
</div></div></blockquote></div><br></div>


[Attachment #6 (text/plain)]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[prev in list] [next in list] [prev in thread] [next in thread]