[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH] mesa: Don't use derived vertex state in api_arrayelt.c
From:       Brian Paul <brian.e.paul () gmail ! com>
Date:       2014-05-06 0:11:46
Message-ID: CAEUUzO_hP9gR3jDnj77HnPBqrLdyGS34aXpNHbZ8FA3sOXZiNg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, May 5, 2014 at 2:49 PM, Fredrik H=C3=B6glund <fredrik@kde.org> wrot=
e:

> On Friday 28 February 2014, Fredrik H=C3=B6glund wrote:
> > Cc: "10.1" <mesa-stable@lists.freedesktop.org>
> > ---
> >  src/mesa/main/api_arrayelt.c | 111
> ++++++++++++++++++++++---------------------
> >  1 file changed, 57 insertions(+), 54 deletions(-)
> >
> > It's possible that this patch fixes a segfault in FlightGear (see bug
> 73504),
> > so I think it's a candidate for the 10.1 branch, but maybe not for
> 10.1.0.
>
> Ping?
>

I took a look.  I guess we don't have much (any?) test coverage of
glArrayElement().  The patch looks good AFAICT.

Reviewed-by: Brian Paul <brianp@vmware.com>

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, May 5, 2014 \
at 2:49 PM, Fredrik Höglund <span dir="ltr">&lt;<a href="mailto:fredrik@kde.org" \
target="_blank">fredrik@kde.org</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">On Friday 28 February 2014, Fredrik Höglund \
wrote:<br> &gt; Cc: &quot;10.1&quot; &lt;<a \
href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>&gt;<br>
 &gt; ---<br>
&gt;   src/mesa/main/api_arrayelt.c | 111 \
++++++++++++++++++++++---------------------<br> &gt;   1 file changed, 57 \
insertions(+), 54 deletions(-)<br> &gt;<br>
&gt; It&#39;s possible that this patch fixes a segfault in FlightGear (see bug \
73504),<br> &gt; so I think it&#39;s a candidate for the 10.1 branch, but maybe not \
for 10.1.0.<br> <br>
Ping?<br></blockquote><div><br></div><div>I took a look.   I guess we don&#39;t have \
much (any?) test coverage of glArrayElement().   The patch looks good \
AFAICT.<br><br>Reviewed-by: Brian Paul &lt;<a \
href="mailto:brianp@vmware.com">brianp@vmware.com</a>&gt;<br> \
</div></div><br><br></div></div>



_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[prev in list] [next in list] [prev in thread] [next in thread]