[prev in list] [next in list] [prev in thread] [next in thread] 

List:       mesa3d-dev
Subject:    Re: [Mesa-dev] [PATCH 03/11] i965: Move has_hiz from the slice to the level.
From:       Chad Versace <chad.versace () linux ! intel ! com>
Date:       2014-05-05 15:52:25
Message-ID: 20140505155225.GA15822 () arabesque ! jf ! intel ! com
[Download RAW message or body]

On Thu, May 01, 2014 at 03:57:28PM -0700, Kenneth Graunke wrote:
> On 05/01/2014 02:21 PM, Eric Anholt wrote:
> > The value depends only on the level, so no need to store the bool per slice.
> > Shrinks intel_mipmap_slice from 24 bytes to 16, while slotting into an
> > existing hole in intel_mipmap_level.
> 
> Huh.  I thought that we needed to disable HiZ for array slices that fell
> on bad boundaries, due to the 11*j thing.
> 
> But you're right, the existing code sure doesn't seem to use it.
> 
> I'd like to see Chad's ack on this.

When i965 still programmed the x/y offset in 3DSTATE_DEPTH_BUFFER to
trick the hardware into rendering to a specific miptree slice, then
hiz-enablement was per-slice. But that ceased being the case as of
20799c11eb8fbdd9adf0baf1d4d5a77c0deb68f3. (DISCLAIMER: I didn't review
207999c myself, but I assume its reviewers took due diligence).

Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[prev in list] [next in list] [prev in thread] [next in thread]